Bug 105993 - Remove superfluous 'IntPoint toPoint(const IntSize&)'
Summary: Remove superfluous 'IntPoint toPoint(const IntSize&)'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 21:19 PST by Steve Block
Modified: 2013-01-02 23:10 PST (History)
12 users (show)

See Also:

Attachments
Patch (8.09 KB, patch)
2013-01-02 21:21 PST, Steve Block 		no flags Details | Formatted Diff | Diff
Patch (8.18 KB, patch)
2013-01-02 22:34 PST, Steve Block 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2013-01-02 21:19:25 PST 
Remove superfluous 'IntPoint toPoint(const IntSize&)'
Comment 1 Steve Block 2013-01-02 21:21:21 PST 
Created attachment 181144 [details]
Patch
Comment 2 Steve Block 2013-01-02 21:22:47 PST 
Note that 'IntPoint toPoint(const IntSize&)' was added in http://trac.webkit.org/changeset/55090
Comment 3 Steve Block 2013-01-02 22:14:51 PST 
Both IntPoint and FloatPoint provide explicit constructors to create objects from IntSize and FloatSize respectively. It would be good to be consistent in using these constructors, rather than toPoint().
Comment 4 Eric Seidel (no email) 2013-01-02 22:17:16 PST 
Comment on attachment 181144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181144&action=review

LGTM.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2171
>      IntSize offsetPoint = point - roundedIntPoint(boundingBoxRect().location());

This variable is confusingly named. :)
Comment 5 Eric Seidel (no email) 2013-01-02 22:17:40 PST 
I didn't mark it r+ since you didn't mark it r? :)
Comment 6 Steve Block 2013-01-02 22:34:12 PST 
Created attachment 181152 [details]
Patch
Comment 7 Steve Block 2013-01-02 22:35:04 PST 
Thanks

> This variable is confusingly named. :)
Done

(I was waiting for the bots before marking r?)
Comment 8 Steve Block 2013-01-02 22:36:27 PST 
Comment on attachment 181152 [details]
Patch

Using Eric's LGTM
Comment 9 WebKit Review Bot 2013-01-02 22:37:56 PST 
Comment on attachment 181152 [details]
Patch

Rejecting attachment 181152 [details] from review queue.

steveblock@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 10 WebKit Review Bot 2013-01-02 22:38:33 PST 
Comment on attachment 181152 [details]
Patch

Rejecting attachment 181152 [details] from commit-queue.

steveblock@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 11 WebKit Review Bot 2013-01-02 23:10:37 PST 
Comment on attachment 181152 [details]
Patch

Clearing flags on attachment: 181152

Committed r138701: <http://trac.webkit.org/changeset/138701>
Comment 12 WebKit Review Bot 2013-01-02 23:10:42 PST 
All reviewed patches have been landed.  Closing bug.