RESOLVED FIXED 105993
Remove superfluous 'IntPoint toPoint(const IntSize&)' 
https://bugs.webkit.org/show_bug.cgi?id=105993
Summary Remove superfluous 'IntPoint toPoint(const IntSize&)'
Steve Block
Reported 2013-01-02 21:19:25 PST
Remove superfluous 'IntPoint toPoint(const IntSize&)'
Attachments
Patch (8.09 KB, patch)
2013-01-02 21:21 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (8.18 KB, patch)
2013-01-02 22:34 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2013-01-02 21:21:21 PST
Created attachment 181144 [details] Patch
Steve Block
Comment 2 2013-01-02 21:22:47 PST
Note that 'IntPoint toPoint(const IntSize&)' was added in http://trac.webkit.org/changeset/55090
Steve Block
Comment 3 2013-01-02 22:14:51 PST
Both IntPoint and FloatPoint provide explicit constructors to create objects from IntSize and FloatSize respectively. It would be good to be consistent in using these constructors, rather than toPoint().
Eric Seidel (no email)
Comment 4 2013-01-02 22:17:16 PST
Comment on attachment 181144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181144&action=review LGTM. > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2171 > IntSize offsetPoint = point - roundedIntPoint(boundingBoxRect().location()); This variable is confusingly named. :)
Eric Seidel (no email)
Comment 5 2013-01-02 22:17:40 PST
I didn't mark it r+ since you didn't mark it r? :)
Steve Block
Comment 6 2013-01-02 22:34:12 PST
Created attachment 181152 [details] Patch
Steve Block
Comment 7 2013-01-02 22:35:04 PST
Thanks > This variable is confusingly named. :) Done (I was waiting for the bots before marking r?)
Steve Block
Comment 8 2013-01-02 22:36:27 PST
Comment on attachment 181152 [details] Patch Using Eric's LGTM
WebKit Review Bot
Comment 9 2013-01-02 22:37:56 PST
Comment on attachment 181152 [details] Patch Rejecting attachment 181152 [details] from review queue. steveblock@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
WebKit Review Bot
Comment 10 2013-01-02 22:38:33 PST
Comment on attachment 181152 [details] Patch Rejecting attachment 181152 [details] from commit-queue. steveblock@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 11 2013-01-02 23:10:37 PST
Comment on attachment 181152 [details] Patch Clearing flags on attachment: 181152 Committed r138701: <http://trac.webkit.org/changeset/138701>
WebKit Review Bot
Comment 12 2013-01-02 23:10:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.