WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED LATER
105990
Substrings of a string from literal should be a string from literal
https://bugs.webkit.org/show_bug.cgi?id=105990
Summary
Substrings of a string from literal should be a string from literal
Benjamin Poulain
Reported
2013-01-02 19:33:42 PST
Let's use a little less memory....
Attachments
Patch
(9.82 KB, patch)
2013-01-02 20:08 PST
,
Benjamin Poulain
buildbot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2013-01-02 20:08:53 PST
Created
attachment 181138
[details]
Patch
Build Bot
Comment 2
2013-01-02 21:59:51 PST
Comment on
attachment 181138
[details]
Patch
Attachment 181138
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/15649547
New failing tests: svg/as-image/img-preserveAspectRatio-support-2.html
Alexey Proskuryakov
Comment 3
2013-01-03 10:05:15 PST
When are we creating substrings of literal strings? Is that common enough for memory savings to offset performance cost of extra branches?
Benjamin Poulain
Comment 4
2013-01-03 13:33:57 PST
(In reply to
comment #3
)
> When are we creating substrings of literal strings? Is that common enough for memory savings to offset performance cost of extra branches?
It is indeed not worth it yet.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug