Bug 105990 - Substrings of a string from literal should be a string from literal
Summary: Substrings of a string from literal should be a string from literal
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2013-01-02 19:33 PST by Benjamin Poulain
Modified: 2013-01-03 13:34 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.82 KB, patch)
2013-01-02 20:08 PST, Benjamin Poulain 		buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-01-02 19:33:42 PST 
Let's use a little less memory....
Comment 1 Benjamin Poulain 2013-01-02 20:08:53 PST 
Created attachment 181138 [details]
Patch
Comment 2 Build Bot 2013-01-02 21:59:51 PST 
Comment on attachment 181138 [details]
Patch

Attachment 181138 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15649547

New failing tests:
svg/as-image/img-preserveAspectRatio-support-2.html
Comment 3 Alexey Proskuryakov 2013-01-03 10:05:15 PST 
When are we creating substrings of literal strings? Is that common enough for memory savings to offset performance cost of extra branches?
Comment 4 Benjamin Poulain 2013-01-03 13:33:57 PST 
(In reply to comment #3)
> When are we creating substrings of literal strings? Is that common enough for memory savings to offset performance cost of extra branches?

It is indeed not worth it yet.