RESOLVED DUPLICATE of bug 105380 105989
[Win] webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode fails 
https://bugs.webkit.org/show_bug.cgi?id=105989
Summary [Win] webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_comman...
Ryosuke Niwa
Reported 2013-01-02 19:28:19 PST
http://build.webkit.org/builders/Apple%20Win%20XP%20Debug%20%28Tests%29/builds/48985/steps/webkitpy-test/logs/stdio 165/1614] webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode erred: Traceback (most recent call last): File "/home/buildbot/slave/win-debug-tests/build/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 149, in test_run_command_with_unicode output = executive.run_command(command_line('echo', unicode_tor_input)) File "/home/buildbot/slave/win-debug-tests/build/Tools/Scripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/home/buildbot/slave/win-debug-tests/build/Tools/Scripts/webkitpy/common/system/executive.py", line 490, in popen string_args = self._stringify_args(args) File "/home/buildbot/slave/win-debug-tests/build/Tools/Scripts/webkitpy/common/system/executive.py", line 477, in _stringify_args string_args = map(unicode, args) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 7: ordinal not in range(128)
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2013-01-02 20:13:24 PST
Maybe we're still double-encoding in the windows case?
Dirk Pranke
Comment 2 2013-01-03 12:44:47 PST
No, that fix just hasn't landed yet, because I was trying to figure out a way to test it cross-platform and then went OOO for a few days. Ryosuke, if this failure is blocking something for you feel free to land/cq+ the change in that bug and I can work on the test separately. *** This bug has been marked as a duplicate of bug 105380 ***
Note You need to log in before you can comment on or make changes to this bug.