Bug 105982 – Adding favicon.ico to the garden-o-matic.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim 'mithro' Ansell]

Adding favicon.ico to the garden-o-matic.

[Tim 'mithro' Ansell]

Created attachment 181130 [details]
Patch

[Tim 'mithro' Ansell]

Created attachment 181132 [details]
Screenshot of the favicon.ico working

[WebKit Review Bot]

Comment on attachment 181130 [details]
Patch

Attachment 181130 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15628766

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Tim 'mithro' Ansell]

Created attachment 181140 [details]
Patch

[Adam Barth]

Why not just use a real file?

[Tim 'mithro' Ansell]

I guess I could use a real file, if you can give me the location to put the file (that is gardener specific)?

[Adam Barth]

Take a look at where the party time graphic is stored.

[Tim 'mithro' Ansell]

Created attachment 181145 [details]
Patch

[Tim 'mithro' Ansell]

Moved to using an on-disk file.

[Adam Barth]

Comment on attachment 181145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181145&action=review

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:34
> +import base64
>  import logging
>  import json
>  import os
>  import sys
> +import tempfile
>  import urllib
> +import zlib

These imports are no longer needed.

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:123
> +        self._serve_file('garden-o-matic.ico')

Why not call it favicon.ico or have the web app use the name garden-o-matic.ico.  It seems odd to change the name here.

In fact, you don't need code at all.  You can just add "ico" to STATIC_FILE_EXTENSIONS

[Tim 'mithro' Ansell]

Created attachment 181150 [details]
Patch

[Tim 'mithro' Ansell]

Comment on attachment 181145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181145&action=review

>> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:123
>> +        self._serve_file('garden-o-matic.ico')
> 
> Why not call it favicon.ico or have the web app use the name garden-o-matic.ico.  It seems odd to change the name here.
> 
> In fact, you don't need code at all.  You can just add "ico" to STATIC_FILE_EXTENSIONS

I was worried that would make this icon used for everything, not just the garden-o-matic.

[Adam Barth]

Comment on attachment 181150 [details]
Patch

It won't.

[Tim 'mithro' Ansell]

Created attachment 181155 [details]
Patch

[Tim 'mithro' Ansell]

As requested. 

The other option was to put a meta tag like below;
<link rel="icon" href="http://www.example.com/garden-o-matric.ico" type="image/x-icon">

[Adam Barth]

Comment on attachment 181155 [details]
Patch

Thanks for iterating on the patch.

[WebKit Review Bot]

Comment on attachment 181155 [details]
Patch

Clearing flags on attachment: 181155

Committed r138713: <http://trac.webkit.org/changeset/138713>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.