We’re seeing failure like this one: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138643%20(4408)/platform/mac/fast/events/numpad-keycode-mapping-pretty-diff.html --- /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/platform/mac/fast/events/numpad-keycode-mapping-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/platform/mac/fast/events/numpad-keycode-mapping-actual.txt @@ -3,24 +3,24 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS getKeyCode('.') is 0x6E -PASS getKeyCode('*') is 0x6A -PASS getKeyCode('+') is 0x6B -PASS getKeyCode('clear') is 0x0C -PASS getKeyCode('/') is 0x6F -PASS getKeyCode('enter') is 0x0D -PASS getKeyCode('-') is 0x6D -PASS getKeyCode('=') is 0xBB -PASS getKeyCode('0') is 0x60 -PASS getKeyCode('1') is 0x61 -PASS getKeyCode('2') is 0x62 -PASS getKeyCode('3') is 0x63 -PASS getKeyCode('4') is 0x64 -PASS getKeyCode('5') is 0x65 -PASS getKeyCode('6') is 0x66 -PASS getKeyCode('7') is 0x67 -PASS getKeyCode('8') is 0x68 -PASS getKeyCode('9') is 0x69 +FAIL getKeyCode('.') should be 110. Was 65. +FAIL getKeyCode('*') should be 106. Was 65. +FAIL getKeyCode('+') should be 107. Was 65. +FAIL getKeyCode('clear') should be 12. Was 65. +FAIL getKeyCode('/') should be 111. Was 65. +FAIL getKeyCode('enter') should be 13. Was 65. +FAIL getKeyCode('-') should be 109. Was 65. +FAIL getKeyCode('=') should be 187. Was 65. +FAIL getKeyCode('0') should be 96. Was 48. +FAIL getKeyCode('1') should be 97. Was 65. +FAIL getKeyCode('2') should be 98. Was 65. +FAIL getKeyCode('3') should be 99. Was 65. +FAIL getKeyCode('4') should be 100. Was 65. +FAIL getKeyCode('5') should be 101. Was 53. +FAIL getKeyCode('6') should be 102. Was 65. +FAIL getKeyCode('7') should be 103. Was 55. +FAIL getKeyCode('8') should be 104. Was 65. +FAIL getKeyCode('9') should be 105. Was 57. PASS successfullyParsed is true TEST COMPLETE
Added a test expectation in http://trac.webkit.org/changeset/138662.
Will fix, sorry for the failure.
Created attachment 181209 [details] Patch
Uploaded patch to fix the WebKitTestRunner failure. Alexey and Ryosuke, could you please take a look? Thanks.
Comment on attachment 181209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181209&action=review > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:370 > + eventCharacter = currentCharacterString; I'm not sure why this assignment is needed. We were not assigning to eventCharacter in the code that you remove.
Comment on attachment 181209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181209&action=review >> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:370 >> + eventCharacter = currentCharacterString; > > I'm not sure why this assignment is needed. We were not assigning to eventCharacter in the code that you remove. For the characters I removed eventCharacter is already set to the correct value. The only cases where it needs to be changed is for for the Clear and Enter keys.
Comment on attachment 181209 [details] Patch Clearing flags on attachment: 181209 Committed r138787: <http://trac.webkit.org/changeset/138787>
All reviewed patches have been landed. Closing bug.