Bug 105948 – fast/events/controlclick-no-onclick.html fails on Mac WK2

• Status: NEW
• Component: UI Events

[Ryosuke Niwa]

The fixed added in http://trac.webkit.org/changeset/138380/trunk/Source/WebCore/page/EventHandler.cpp needs to run on Mac WK2 as well.

[Ryosuke Niwa]

The test is currently failing on Mac WK2:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fevents%2Fcontrolclick-no-onclick.html

I'll take a look tomorrow. Does EWS not run WK2 tests?

[Ryosuke Niwa]

Added a test expectation in http://trac.webkit.org/changeset/138648.

[Ryosuke Niwa]

(In reply to comment #2)
> I'll take a look tomorrow. Does EWS not run WK2 tests?

Unfortunately not. Mac EWS uses Mac WK1.

How do I run WK2 tests locally?

[Ryosuke Niwa]

run-webkit-tests -2.

Simply enabling the new code path on WK2 is not enough as the WebKitTestRunner actually brings up a context menu by the test, which doesn't get dismissed in the test environment.

Hmm, the context menu getting opened only seems to happen if the test is run by itself, and it also happens for me on fast/events/context-nodrag.html - which is a test that passes on the bots. So that part may not actually be a problem.

Actually, my previous comment wasn't quite correct.

Turns out all of the context menu tests are disabled on Mac WK2 (under various bugs):

via LayoutTests/platform/wk2:
fast/events/context-nodrag.html
editing/selection/context-menu-text-selection.html

via LayoutTests/platform/mac-wk2:
fast/events/content-changed-during-drop.html
fast/events/context-no-deselect.html
fast/events/context-onmousedown-event.html
fast/events/contextmenu-scrolled-page-with-frame.html
editing/selection/context-menu-on-text.html

All of them have the problem that a modal context menu is brought up, blocking the test from completing, like this test.

cc'ing Wojciech Bielawski, who worked on adding eventSender.contextClick() to the wk2 test harness (https://bugs.webkit.org/show_bug.cgi?id=86881).