Bug 105943 – Canvas blending tests fail on Mac WK2

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Ryosuke Niwa]

It appears that http://trac.webkit.org/changeset/138334 didn’t update the WK2 code properly.

[Ryosuke Niwa]

Added a test expectation in http://trac.webkit.org/changeset/138643.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fcanvas%2Fcanvas-blend-image.html%2Cfast%2Fcanvas%2Fcanvas-blend-solid.html

http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138637%20(4403)/fast/canvas/canvas-blend-image-pretty-diff.html
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138637%20(4403)/fast/canvas/canvas-blend-image-pretty-diff.html

[Simon Fraser (smfr)]

There should be no WK2-specific canvas code. Maybe this is the issue where composited content has color matching issues?

[Rik Cabanier]

(In reply to comment #2)
> There should be no WK2-specific canvas code. Maybe this is the issue where composited content has color matching issues?

It seems that the preference is not passed to the WebKitProcess so it always executes as accelerated, even when turned off.

[Rik Cabanier]

Created attachment 181192 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 181192 [details]
Patch

InternalSettings::Backup need to save/restore this pref too.

[Rik Cabanier]

(In reply to comment #5)
> (From update of attachment 181192 [details])
> InternalSettings::Backup need to save/restore this pref too.

will do

[Rik Cabanier]

Created attachment 181194 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 181194 [details]
Patch

Excellent! Thanks for the timely fix!

[WebKit Review Bot]

Comment on attachment 181194 [details]
Patch

Clearing flags on attachment: 181194

Committed r138726: <http://trac.webkit.org/changeset/138726>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.