Bug 105928 – [Qt] Use WebPageProxy::postMessageToInjectedBundle when passing messages to a specific page in the builtin bundle

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Caio Marcelo de Oliveira Filho]

[Qt] Use WebPageProxy::postMessageToInjectedBundle when passing messages to a specific page in the builtin bundle

[Caio Marcelo de Oliveira Filho]

Created attachment 181036 [details]
Patch

[Caio Marcelo de Oliveira Filho]

Committed r138723: <http://trac.webkit.org/changeset/138723>

[Csaba Osztrogonác]

Comment on attachment 181036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181036&action=review

It broke the debug build and I fixed it - https://trac.webkit.org/changeset/138749
( Please check the debug build next time if you modify an assertion. )

> Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:101
> +    ASSERT(WKGetTypeID(messageBody) == WKStringGetTypeID());
> +    WKStringRef contents = static_cast<WKStringRef>(messageBody);

/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp: In member function 'void WebKit::QtBuiltinBundle::handleMessageToNavigatorQtObject(const OpaqueWKBundlePage*, const void*)':
/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:100: error: 'WKGetTypeID' was not declared in this scope

> Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:113
> +    ASSERT(WKGetTypeID(messageBody) == WKBooleanGetTypeID());
> +    WKBooleanRef enabled = static_cast<WKBooleanRef>(messageBody);

/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp: In member function 'void WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled(const OpaqueWKBundlePage*, const void*)':
/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:112: error: 'WKGetTypeID' was not declared in this scope

[Caio Marcelo de Oliveira Filho]

(In reply to comment #3)
> (From update of attachment 181036 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181036&action=review
> 
> It broke the debug build and I fixed it - https://trac.webkit.org/changeset/138749
> ( Please check the debug build next time if you modify an assertion. )

Thanks, Ossy. Sorry for the noise.