Bug 105928 - [Qt] Use WebPageProxy::postMessageToInjectedBundle when passing messages to a specific page in the builtin bundle
Summary: [Qt] Use WebPageProxy::postMessageToInjectedBundle when passing messages to a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 10:20 PST by Caio Marcelo de Oliveira Filho
Modified: 2013-01-03 15:10 PST (History)
4 users (show)

See Also:


Attachments
Patch (12.10 KB, patch)
2013-01-02 11:01 PST, Caio Marcelo de Oliveira Filho
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2013-01-02 10:20:49 PST
[Qt] Use WebPageProxy::postMessageToInjectedBundle when passing messages to a specific page in the builtin bundle
Comment 1 Caio Marcelo de Oliveira Filho 2013-01-02 11:01:30 PST
Created attachment 181036 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2013-01-03 11:25:58 PST
Committed r138723: <http://trac.webkit.org/changeset/138723>
Comment 3 Csaba Osztrogonác 2013-01-03 15:06:21 PST
Comment on attachment 181036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181036&action=review

It broke the debug build and I fixed it - https://trac.webkit.org/changeset/138749
( Please check the debug build next time if you modify an assertion. )

> Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:101
> +    ASSERT(WKGetTypeID(messageBody) == WKStringGetTypeID());
> +    WKStringRef contents = static_cast<WKStringRef>(messageBody);

/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp: In member function 'void WebKit::QtBuiltinBundle::handleMessageToNavigatorQtObject(const OpaqueWKBundlePage*, const void*)':
/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:100: error: 'WKGetTypeID' was not declared in this scope

> Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:113
> +    ASSERT(WKGetTypeID(messageBody) == WKBooleanGetTypeID());
> +    WKBooleanRef enabled = static_cast<WKBooleanRef>(messageBody);

/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp: In member function 'void WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled(const OpaqueWKBundlePage*, const void*)':
/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:112: error: 'WKGetTypeID' was not declared in this scope
Comment 4 Caio Marcelo de Oliveira Filho 2013-01-03 15:10:16 PST
(In reply to comment #3)
> (From update of attachment 181036 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181036&action=review
> 
> It broke the debug build and I fixed it - https://trac.webkit.org/changeset/138749
> ( Please check the debug build next time if you modify an assertion. )

Thanks, Ossy. Sorry for the noise.