WebKitWebAudioSourceGStreamer uses a GStaticRecMutex, which is deprecated since glib 2.32 in favor of GRecMutex, and hence produces a compilation warning with -Wdeprecated-declarations. ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: In function ‘void webkit_web_audio_src_init(WebKitWebAudioSrc*)’: ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:193:5: warning: ‘void g_static_rec_mutex_init(GStaticRecMutex*)’ is deprecated (declared at /usr/local/devel/gnome3/include/glib-2.0/glib/deprecated/gthread.h:170): Use 'g_rec_mutex_init' instead [-Wdeprecated-declarations] ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:193:41: warning: ‘void g_static_rec_mutex_init(GStaticRecMutex*)’ is deprecated (declared at /usr/local/devel/gnome3/include/glib-2.0/glib/deprecated/gthread.h:170): Use 'g_rec_mutex_init' instead [-Wdeprecated-declarations] ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: In function ‘void webKitWebAudioSrcFinalize(GObject*)’: ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:266:5: warning: ‘void g_static_rec_mutex_free(GStaticRecMutex*)’ is deprecated (declared at /usr/local/devel/gnome3/include/glib-2.0/glib/deprecated/gthread.h:189): Use 'g_rec_mutex_free' instead [-Wdeprecated-declarations] ../../Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:266:41: warning: ‘void g_static_rec_mutex_free(GStaticRecMutex*)’ is deprecated (declared at /usr/local/devel/gnome3/include/glib-2.0/glib/deprecated/gthread.h:189): Use 'g_rec_mutex_free' instead [-Wdeprecated-declarations] However, we cannot change that since it's needed by gst_task_set_lock() in GStreamer 0.10. So we should disable the deprecation warning for those function calls.
Created attachment 181025 [details] Patch
Comment on attachment 181025 [details] Patch I think this is a lot of preprocessor code just to fix a compile warning that is harmless.
Created attachment 181026 [details] Patch v2 (In reply to comment #2) > I think this is a lot of preprocessor code just to fix a compile > warning that is harmless. Here's a much simpler and readable version. The difference is that it would disable the deprecation warnings in the whole file (which is anyway less than 400 lines of code).
I don't think this patch is needed now that the webaudio backend is ported to gst 1.0
(In reply to comment #4) > I don't think this patch is needed now that the webaudio backend is ported to gst 1.0 I see, we could still keep it if we're using the old API, but I guess it's not so important. Feel free to close this bug then.
Comment on attachment 181025 [details] Patch Obsoleted by v2
Comment on attachment 181026 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=181026&action=review > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:34 > +#if (COMPILER(GCC) && GCC_VERSION_AT_LEAST(4, 6, 0)) Alright maybe another condition can be added there? !defined(GST_API_VERSION_1) So later on when we remove the 0.10 support we'll make sure to remove this code as well.
Created attachment 181516 [details] Patch v3
Comment on attachment 181516 [details] Patch v3 Clearing flags on attachment: 181516 Committed r138960: <http://trac.webkit.org/changeset/138960>
All reviewed patches have been landed. Closing bug.