WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105910
Remove webkitPostMessage
https://bugs.webkit.org/show_bug.cgi?id=105910
Summary
Remove webkitPostMessage
Adam Barth
Reported
2013-01-02 01:05:52 PST
Remove webkitPostMessage
Attachments
Patch
(14.69 KB, patch)
2013-01-02 01:11 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2013-01-02 01:11:24 PST
Created
attachment 181012
[details]
Patch
Kentaro Hara
Comment 2
2013-01-02 01:15:34 PST
Comment on
attachment 181012
[details]
Patch As far as I see the discussion in webkit-dev, I think we have done the process of feature deprecation (
https://trac.webkit.org/wiki/DeprecatingFeatures
)
Adam Barth
Comment 3
2013-01-02 01:21:22 PST
Comment on
attachment 181012
[details]
Patch I'm going to give folks a chance to comment on webkit-dev before landing. I shouldn't have set commit-queue? when posting my patch. Thanks for the review.
Kentaro Hara
Comment 4
2013-01-02 01:34:48 PST
Comment on
attachment 181012
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=181012&action=review
> Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:44 > +v8::Handle<v8::Value> V8DedicatedWorkerContext::postMessageCallback(const v8::Arguments& args)
We might want to share the code of V8XXX::postMessageCallback()s, just like JSC's handlePostMessage() does. (We can do it in a follow-up patch.)
Adam Barth
Comment 5
2013-01-02 02:07:01 PST
Good idea.
WebKit Review Bot
Comment 6
2013-01-02 14:15:46 PST
Comment on
attachment 181012
[details]
Patch Clearing flags on attachment: 181012 Committed
r138646
: <
http://trac.webkit.org/changeset/138646
>
WebKit Review Bot
Comment 7
2013-01-02 14:15:50 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug