Bug 105906 – [BlackBerry] Handle re-entrant destruction of MediaPlayerPrivate while a dialog is up

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Max Feil]

Now that dialogs are not truly modal anymore, we need to handle the case where MediaPlayerPrivate gets destroyed by re-entrant calls while a dialog is up. The re-entrant calls come via the nested event handler that is set up by the dialog code. This nested event handler does defer page loads, but this is not enough to ensure that MediaPlayerPrivate objects don't get destroyed. They can be destroyed by simply changing the source of an audio or video element, for example in a canplaythrough event handler.

This patch covers only the WebCore side of the changes required. Most of the work is in the platform repository. See PR272949.

[Max Feil]

Created attachment 181008 [details]
Patch

[Max Feil]

Comment on attachment 181008 [details]
Patch

BlackBerry Specific patch, already reviewed by George Staikos.

[WebKit Review Bot]

Comment on attachment 181008 [details]
Patch

Rejecting attachment 181008 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 181008 [details]
Patch

Rejecting attachment 181008 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Max Feil]

Comment on attachment 181008 [details]
Patch

Alrighty then.

[Max Feil]

I'd like to upstream this change, which is already reviewed and landed downstream...

[WebKit Review Bot]

Comment on attachment 181008 [details]
Patch

Clearing flags on attachment: 181008

Committed r138805: <http://trac.webkit.org/changeset/138805>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.