Bug 105899 - Pass through SynchronousRequestAttribute to QNetworkReplyHandler::start
Summary: Pass through SynchronousRequestAttribute to QNetworkReplyHandler::start
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-01 14:16 PST by Azat Khuzhin
Modified: 2013-10-02 12:28 PDT (History)
1 user (show)

See Also:


Attachments
Pass through SynchronousRequestAttribute to QNetworkReplyHandler::start (1.63 KB, patch)
2013-01-01 14:20 PST, Azat Khuzhin
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
002-Pass through SynchronousRequestAttribute to QNetworkReplyHandler::start (1.69 KB, patch)
2013-01-08 14:08 PST, Azat Khuzhin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Azat Khuzhin 2013-01-01 14:16:56 PST
If you try to set "SynchronousRequestAttribute" from "QNetworkAccessManager::createRequest"
<pre>
    QNetworkRequest nonConstRequest(request);
    nonConstRequest.setAttribute(QNetworkRequest::SynchronousRequestAttribute, true);
    QNetworkReply *reply = QNetworkAccessManager::createRequest(operation, nonConstRequest, outgoingData);
    return reply;
</pre>
Qt webkit browser didn't render page, because it just load one resource, and all pending not.

In my opinion because after "QNetworkAccessManager::createRequest" request already finished, and when webkit attach to finished() signal non of event will be triggered.

After some investigations, I'v write a little patch (attached).
This must fix issue.
Comment 1 Azat Khuzhin 2013-01-01 14:20:58 PST
Created attachment 180996 [details]
Pass through SynchronousRequestAttribute to QNetworkReplyHandler::start
Comment 2 Early Warning System Bot 2013-01-08 08:58:33 PST
Comment on attachment 180996 [details]
Pass through SynchronousRequestAttribute to QNetworkReplyHandler::start

Attachment 180996 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15762135
Comment 3 Early Warning System Bot 2013-01-08 09:01:27 PST
Comment on attachment 180996 [details]
Pass through SynchronousRequestAttribute to QNetworkReplyHandler::start

Attachment 180996 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15771086
Comment 4 Azat Khuzhin 2013-01-08 14:08:10 PST
Created attachment 181757 [details]
002-Pass through SynchronousRequestAttribute to QNetworkReplyHandler::start
Comment 5 Azat Khuzhin 2013-01-08 14:12:11 PST
New fixed patch attached

First one was totally wrong, because I looked at the wrong place of diff.
Comment 6 Azat Khuzhin 2013-01-27 12:13:59 PST
Any news?