Bug 105897 - [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
Summary: [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-01 06:06 PST by Chris Dumez
Modified: 2013-01-01 22:54 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.38 KB, patch)
2013-01-01 06:10 PST, Chris Dumez 		ap: review+
Details | Formatted Diff | Diff
Patch for landing (5.30 KB, patch)
2013-01-01 22:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-01-01 06:06:48 PST 
plugins/clicking-missing-plugin-fires-delegate.html is failing on WK2 due to missing WebKitTestRunner dumping:

diff:
- MISSING PLUGIN BUTTON PRESSED
Comment 1 Chris Dumez 2013-01-01 06:10:48 PST 
Created attachment 180990 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-01-01 20:45:03 PST 
Comment on attachment 180990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180990&action=review

> Tools/WebKitTestRunner/TestController.cpp:1112
> +void TestController::unavailablePluginButtonClicked(WKPageRef, WKPluginUnavailabilityReason, WKStringRef /*mimeType*/, WKStringRef /*url*/, WKStringRef /*pluginsPageURL*/, const void*)

I would leave arguments names completely, not just comment them out. They are not even present in header.
Comment 3 Chris Dumez 2013-01-01 22:37:42 PST 
Created attachment 181009 [details]
Patch for landing

Removed commented argument names.
Comment 4 WebKit Review Bot 2013-01-01 22:54:43 PST 
Comment on attachment 181009 [details]
Patch for landing

Clearing flags on attachment: 181009

Committed r138608: <http://trac.webkit.org/changeset/138608>
Comment 5 WebKit Review Bot 2013-01-01 22:54:47 PST 
All reviewed patches have been landed.  Closing bug.