Bug 105892 – Objective-C API: Objective-C functions exposed to JavaScript have the wrong type (object instead of function)

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

The current implementation ttys to implement a JavaScript Function object via the C-API - it does so imperfectly.

[Geoffrey Garen]

ObjCCallbackFunction should subclass JSFunction or InternalFunction.

[Mark Hahnenberg]

Created attachment 192590 [details]
Patch

[Early Warning System Bot]

Comment on attachment 192590 [details]
Patch

Attachment 192590 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17121421

[Early Warning System Bot]

Comment on attachment 192590 [details]
Patch

Attachment 192590 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17178092

[Mark Hahnenberg]

Created attachment 192592 [details]
Patch

[Early Warning System Bot]

Comment on attachment 192592 [details]
Patch

Attachment 192592 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17013883

[Early Warning System Bot]

Comment on attachment 192592 [details]
Patch

Attachment 192592 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17177390

[Mark Hahnenberg]

Created attachment 192596 [details]
Patch

[Early Warning System Bot]

Comment on attachment 192596 [details]
Patch

Attachment 192596 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17149383

[Early Warning System Bot]

Comment on attachment 192596 [details]
Patch

Attachment 192596 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17024541

[Mark Hahnenberg]

Created attachment 192606 [details]
Patch

[Mark Hahnenberg]

<rdar://problem/12954243>

[Geoffrey Garen]

Comment on attachment 192606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192606&action=review

r=me

> Source/JavaScriptCore/API/ObjCCallbackFunction.mm:586
> +    return toRef(JSC::ObjCCallbackFunction::create(exec, exec->lexicalGlobalObject(), "Objective-C", impl.release()));

Should we just leave the function anonymous, instead? I agree that at the JS-mangled selector name would be better, but I don't think "Objective-C" adds all that much.

> Source/JavaScriptCore/API/tests/testapi.mm:526
> +        JSValue *result = [context evaluateScript:@"Function.prototype.toString.call(testObject.callback)"];
> +        checkResult(@"callback function typeof", !context.exception && ![result isUndefined]);

This test doesn't actually test typeof. You should name this test "toString', and write a separate test line for typeof that shows it's "Function".

[Mark Hahnenberg]

Committed r145848: <http://trac.webkit.org/changeset/145848>

[Mark Hahnenberg]

Comment on attachment 192606 [details]
Patch

Clearing flags.