Bug 105890 – Convert more classes to be WebContextSupplements

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Convert more classes to be WebContextSupplements

[Sam Weinig]

Created attachment 180982 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Review Bot]

Attachment 180982 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/C/WKContext.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 180982 [details]
Patch

Attachment 180982 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15603645

[kov's GTK+ EWS bot]

Comment on attachment 180982 [details]
Patch

Attachment 180982 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15592988

[Sam Weinig]

Created attachment 180983 [details]
Patch

[WebKit Review Bot]

Attachment 180983 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/C/WKContext.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Committed r138607: <http://trac.webkit.org/changeset/138607>

[Chris Dumez]

Comment on attachment 180983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180983&action=review

> Source/WebKit2/UIProcess/WebContext.cpp:178
> +    addSupplement<WebNotificationManagerProxy>();

Missing addSupplement<WebIconDatabase>(); ?

It is a lot causing crashes on EFL port:
20:33:03.001 19851 worker/1 http/tests/css/border-image-loading.html crashed, (stderr lines):
20:33:03.002 19851   1   0x7f88965a05e8
20:33:03.002 19851   2   0x7f8893ccb4a0
20:33:03.002 19851   3   0x7f8895d7d690 WebKit::WebIconDatabase::isOpen()
20:33:03.002 19851   4   0x7f8895d7d6d3 WebKit::WebIconDatabase::setDatabasePath(WTF::String const&)
20:33:03.002 19851   5   0x410c0e WTR::TestController::initialize(int, char const**)
20:33:03.002 19851   6   0x411a86 WTR::TestController::TestController(int, char const**)
20:33:03.002 19851   7   0x40bf44 main
20:33:03.002 19851   8   0x7f8893cb676d __libc_start_main
20:33:03.002 19851   9   0x40bf91

[Chris Dumez]

I filed Bug 105909 to track the regression.

[Csaba Osztrogonác]

(In reply to comment #8)
> Committed r138607: <http://trac.webkit.org/changeset/138607>

It broke all layout test crash on WK2:
- Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/12187
- EFL: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/2232
- GTK: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/builds/3797
- Apple Mac WK2 bots are still out of order:
  - http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK2%20%28Tests%29?numbuilds=200 - everything fails long time ago
  - http://build.webkit.org/builders/Apple%20Lion%20Release%20WK2%20%28Tests%29 - offline long time ago
  - http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29 - went offline after this patch
  - http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29 - offline long time ago

[Chris Dumez]

(In reply to comment #11)
> (In reply to comment #8)
> > Committed r138607: <http://trac.webkit.org/changeset/138607>
> 
> It broke all layout test crash on WK2:
> - Qt: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/12187
> - EFL: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/2232
> - GTK: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/builds/3797
> - Apple Mac WK2 bots are still out of order:
>   - http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK2%20%28Tests%29?numbuilds=200 - everything fails long time ago
>   - http://build.webkit.org/builders/Apple%20Lion%20Release%20WK2%20%28Tests%29 - offline long time ago
>   - http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29 - went offline after this patch
>   - http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29 - offline long time ago

Yes, I filed Bug 105909. I may have a fix but I'm still building it to test it.