Bug 105878 - Add supplementability for WebContext
Summary: Add supplementability for WebContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-30 18:45 PST by Sam Weinig
Modified: 2013-01-02 09:59 PST (History)
0 users

See Also:

Attachments
Patch (21.01 KB, patch)
2012-12-30 18:46 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-12-30 18:45:39 PST 
Add supplementability for WebContext
Comment 1 Sam Weinig 2012-12-30 18:46:39 PST 
Created attachment 180962 [details]
Patch
Comment 2 mitz 2012-12-31 11:47:21 PST 
Comment on attachment 180962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review

> Source/WebKit2/UIProcess/API/C/WKContext.cpp:39
> +

!
Comment 3 Sam Weinig 2012-12-31 11:54:39 PST 
Committed r138599: <http://trac.webkit.org/changeset/138599>
Comment 4 Adam Barth 2013-01-02 00:40:16 PST 
Comment on attachment 180962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review

I was curious about the approach, and I noticed one nit below.  Please feel free to ignore my nitpicking.  :)

> Source/WebKit2/UIProcess/WebContextSupplement.h:36
> +    WebContextSupplement(WebContext* context)

One-argument constructors should use the "explicit" keyword (unless you really wan the implicit conversions, which seems unlikely here)
Comment 5 Sam Weinig 2013-01-02 09:59:07 PST 
(In reply to comment #4)
> (From update of attachment 180962 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review
> 
> I was curious about the approach, and I noticed one nit below.  Please feel free to ignore my nitpicking.  :)

I just trying to break things up into to existing abstractions right now, not much approach going on. 

> 
> > Source/WebKit2/UIProcess/WebContextSupplement.h:36
> > +    WebContextSupplement(WebContext* context)
> 
> One-argument constructors should use the "explicit" keyword (unless you really wan the implicit conversions, which seems unlikely here)

Indeed, will fix.