Bug 105855 - Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
Summary: Web Inspector: Native Memory Instrumentation plugin: do not generate 'not ins...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on:
Reported: 2012-12-29 03:24 PST by Ilya Tikhonovsky
Modified: 2012-12-29 03:39 PST (History)
8 users (show)

See Also:

Patch (3.75 KB, patch)
2012-12-29 03:28 PST, Ilya Tikhonovsky
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-12-29 03:24:17 PST
Plugin scans all methods in the translation unit,
visits methods with reportMemoryUsage name and 
collects all the reported class members into instrumentedMembers vector.

Actually it visits all call expressions inside reportMemoryUsage method
and only if the method name of call expression matches with predefined set of
instrumentation methods, addMember, addRawPointer etc. then it scans all
the arguments of the call expression. It expects that argument has type MemberExpr but for
the mutable members the type of the expression is ImplicitCastExpr because it
needs to be converted into const T& where T is a template argument of addMember method.
Comment 1 Ilya Tikhonovsky 2012-12-29 03:28:48 PST
Created attachment 180930 [details]
Comment 2 Ilya Tikhonovsky 2012-12-29 03:39:33 PST
Committed r138563: <http://trac.webkit.org/changeset/138563>