Bug 105853 – [EFL][WK2] Failure to build when Elementary is built with certain options.

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit EFL

[Doug Newgard]

[ 98%] Building CXX object  Tools/WebkitTestRunner/CMakeFiles/TestRunnerInjectedBundle.dir/InjectedBundle/InjectedBundle.cpp.o
In file included from /var/abs/local/yaourtbuild/ewebkit-svn/src/Webkit-build/Tools/MiniBrowser/efl/main.c:25:0:
/usr/include/elementary-1/Elementary.h:82:19: fatal error: EDBus.h: No such file or directory
compilation terminated
make[2]: *** [Tools/MiniBrowser/efl/CMakeFiles/MiniBrowser.dir/main.c.o] Error 1
make[1]: *** [Tools/MiniBrowser/efl/CMakeFiles/MiniBrowser.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs


This is similar to the problem here: https://bugs.webkit.org/show_bug.cgi?id=103360. Unfortunately, the "fix" on that one is a pretty bad hack, as some people use elementary for things other than just WebKit and may need those options. Requiring that a shared lib be built with support for something is one thing, but requiring that it be built without support for something? There's got to be a better way.

[Ryuan Choi]

Created attachment 215033 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 215033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215033&action=review

> Source/cmake/FindElementary.cmake:48
> +    EMap

Though we disabled emap, ethumb in Bug 103360, I wonder why we should include unused headers.

[Ryuan Choi]

Comment on attachment 215033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215033&action=review

>> Source/cmake/FindElementary.cmake:48
>> +    EMap
> 
> Though we disabled emap, ethumb in Bug 103360, I wonder why we should include unused headers.

It's for develepers to build webkit on their EFL environment instead of jhbuild.
Bug 103360 is just for developers to build webkit using jhbuild.

I considered to move these header files from Elementary.h at that time,
but I realized that it looks not easy because it was intended and some header files are really required when elementary was built with these options.

[Gyuyoung Kim]

Ryuan, do you still need to land this patch ?

[Ryuan Choi]

(In reply to comment #4)
> Ryuan, do you still need to land this patch ?

Now, this is only required for the EFL developers who still use 1.7.x.
I am not sure whether we should consider them.

I believe that almost EFL developers are now using 1.8.x or latest version(1.8.99 for 1.9 release).

[Gyuyoung Kim]

Comment on attachment 215033 [details]
Patch

Clear review? from attachment 215033 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug or this bug again.

[Ryuan Choi]

Nowadays, I don't believe that we should consider 1.7.x