Bug 105836 – getComputedStyle returns "left" instead of "none" for "float" on abspos elements

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mike Sherov]

http://www.w3.org/TR/css3-positioning/ Section 8:
> if ‘position’ has the value absolute, page or fixed, and the value of float is left or right, the box is absolutely positioned and the computed value of float is none.

Webkit incorrectly returns "left". This has surfaced as a jQuery bug: http://bugs.jquery.com/ticket/13126#comment:1

Here's a jsfiddle demonstrating the problem: http://jsfiddle.net/ChPCD/7/ Note the output says "left" for "absolute" instead of "none". 

The same test case returns correct values in FF15, Opera 12, and IE9+

[Uday Kiran]

Created attachment 184924 [details]
Proposed patch

[Tony Chang]

Comment on attachment 184924 [details]
Proposed patch

I mentioned on IRC that CSSComputedStyleDeclaration.cpp might be a better place for this type of change since we don't need to change the style for rendering.

[Uday Kiran]

Created attachment 185008 [details]
Patch

Fixed review comments.

[Uday Kiran]

Created attachment 185014 [details]
Patch

[Tony Chang]

Comment on attachment 185014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185014&action=review

> LayoutTests/ChangeLog:10
> +        If 'position' has the value absolute, page or fixed, and the value of float is
> +        left or right, the box is absolutely positioned and the computed value of float is none.
> +        http://www.w3.org/TR/css3-positioning/#dis-pos-flo

Please mention that this matches Firefox and IE.  BTW, do you know of any websites that depend on this behavior?

[Uday Kiran]

Created attachment 185027 [details]
Patch

Updated ChangeLog

[Uday Kiran]

Thanks for review.

(In reply to comment #5)
> (From update of attachment 185014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=185014&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        If 'position' has the value absolute, page or fixed, and the value of float is
> > +        left or right, the box is absolutely positioned and the computed value of float is none.
> > +        http://www.w3.org/TR/css3-positioning/#dis-pos-flo
> 
> Please mention that this matches Firefox and IE.  BTW, do you know of any websites that depend on this behavior?

Fixed ChangeLog. Sorry I am not aware of websites.
Can I carry-forward your r+ to next patch? If yes, how do I do it with webkit-patch?

[Tony Chang]

Comment on attachment 185027 [details]
Patch

When the previous patch still had r+, you can use 'webkit-patch land-safely' to forward on the review flag.

[Uday Kiran]

(In reply to comment #8)
> (From update of attachment 185027 [details])
> When the previous patch still had r+, you can use 'webkit-patch land-safely' to forward on the review flag.

Thanks. Will remember it from next time :)

[WebKit Review Bot]

Comment on attachment 185027 [details]
Patch

Clearing flags on attachment: 185027

Committed r140993: <http://trac.webkit.org/changeset/140993>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.