Bug 105829 - Web Inspector: refactor DefaultTextEditor - annotate handlers and fix getters style
Summary: Web Inspector: refactor DefaultTextEditor - annotate handlers and fix getters...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-28 06:58 PST by Andrey Lushnikov
Modified: 2012-12-29 01:20 PST (History)
9 users (show)

See Also:

Attachments
Patch (14.86 KB, patch)
2012-12-28 07:04 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (15.03 KB, patch)
2012-12-28 08:42 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2012-12-28 06:58:38 PST 
Refactor DefaultTextEditor's classes to loosen their coupling.
Comment 1 Andrey Lushnikov 2012-12-28 07:04:42 PST 
Created attachment 180871 [details]
Patch
Comment 2 Pavel Feldman 2012-12-28 07:51:13 PST 
Comment on attachment 180871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180871&action=review

> Source/WebCore/ChangeLog:3
> +        Web Inspector: refactor DefaultTextEditor

Please be more specific.

> Source/WebCore/ChangeLog:8
> +        Refactor DefaultTextEditor to separate its classes.

Please explain briefly what has changed and why.
Comment 3 Andrey Lushnikov 2012-12-28 08:42:41 PST 
Created attachment 180878 [details]
Patch
Comment 4 WebKit Review Bot 2012-12-29 01:20:49 PST 
Comment on attachment 180878 [details]
Patch

Clearing flags on attachment: 180878

Committed r138560: <http://trac.webkit.org/changeset/138560>
Comment 5 WebKit Review Bot 2012-12-29 01:20:53 PST 
All reviewed patches have been landed.  Closing bug.