WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105829
Web Inspector: refactor DefaultTextEditor - annotate handlers and fix getters style
https://bugs.webkit.org/show_bug.cgi?id=105829
Summary
Web Inspector: refactor DefaultTextEditor - annotate handlers and fix getters...
Andrey Lushnikov
Reported
2012-12-28 06:58:38 PST
Refactor DefaultTextEditor's classes to loosen their coupling.
Attachments
Patch
(14.86 KB, patch)
2012-12-28 07:04 PST
,
Andrey Lushnikov
no flags
Details
Formatted Diff
Diff
Patch
(15.03 KB, patch)
2012-12-28 08:42 PST
,
Andrey Lushnikov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1
2012-12-28 07:04:42 PST
Created
attachment 180871
[details]
Patch
Pavel Feldman
Comment 2
2012-12-28 07:51:13 PST
Comment on
attachment 180871
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=180871&action=review
> Source/WebCore/ChangeLog:3 > + Web Inspector: refactor DefaultTextEditor
Please be more specific.
> Source/WebCore/ChangeLog:8 > + Refactor DefaultTextEditor to separate its classes.
Please explain briefly what has changed and why.
Andrey Lushnikov
Comment 3
2012-12-28 08:42:41 PST
Created
attachment 180878
[details]
Patch
WebKit Review Bot
Comment 4
2012-12-29 01:20:49 PST
Comment on
attachment 180878
[details]
Patch Clearing flags on attachment: 180878 Committed
r138560
: <
http://trac.webkit.org/changeset/138560
>
WebKit Review Bot
Comment 5
2012-12-29 01:20:53 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug