Bug 105822 - Web Inspector: [Canvas] add an option to reload the page if there is an uninstrumented canvas
Summary: Web Inspector: [Canvas] add an option to reload the page if there is an unins...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-28 01:11 PST by Andrey Adaikin
Modified: 2013-01-10 22:58 PST (History)
10 users (show)

See Also:


Attachments
Patch (5.38 KB, patch)
2012-12-28 01:12 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff
Screenshot (651.58 KB, image/png)
2012-12-28 01:13 PST, Andrey Adaikin
no flags Details
Patch (5.92 KB, patch)
2012-12-28 06:10 PST, Andrey Adaikin
no flags Details | Formatted Diff | Diff
Patch (7.02 KB, patch)
2012-12-29 06:43 PST, Andrey Adaikin
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-12-28 01:11:17 PST
Patch to follow.
Comment 1 Andrey Adaikin 2012-12-28 01:12:59 PST
Created attachment 180853 [details]
Patch
Comment 2 Andrey Adaikin 2012-12-28 01:13:49 PST
Created attachment 180854 [details]
Screenshot
Comment 3 Pavel Feldman 2012-12-28 04:50:47 PST
Comment on attachment 180853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180853&action=review

> Source/WebCore/inspector/front-end/CanvasProfileView.js:203
> +    this._decorationElement = document.createElement("div");

You should only use css for styling.
Comment 4 Andrey Adaikin 2012-12-28 06:10:27 PST
Created attachment 180868 [details]
Patch
Comment 5 Pavel Feldman 2012-12-29 04:40:14 PST
Comment on attachment 180868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180868&action=review

> Source/WebCore/inspector/front-end/CanvasProfileView.js:205
> +    this._decorationElement.style.display = "none";

"hidden" style class would do that for you.

> Source/WebCore/inspector/front-end/CanvasProfileView.js:209
> +    reloadPageButton.textContent = "Reload";

This should be localized

> Source/WebCore/inspector/front-end/CanvasProfileView.js:298
> +            this._decorationElement.style.display = showWarning ? "" : "none";

ditto
Comment 6 Andrey Adaikin 2012-12-29 06:43:29 PST
Created attachment 180936 [details]
Patch
Comment 7 WebKit Review Bot 2012-12-29 07:28:28 PST
Comment on attachment 180936 [details]
Patch

Attachment 180936 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15582400

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 8 WebKit Review Bot 2013-01-10 22:52:47 PST
Comment on attachment 180936 [details]
Patch

Rejecting attachment 180936 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15801335
Comment 9 Andrey Adaikin 2013-01-10 22:58:43 PST
Committed r139408: <http://trac.webkit.org/changeset/139408>