Bug 105809 - [Texmap] Use a transform uniform instead of u_flip/u_textureSize
Summary: [Texmap] Use a transform uniform instead of u_flip/u_textureSize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on: 105377
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-27 15:20 PST by Noam Rosenthal
Modified: 2012-12-28 21:11 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.68 KB, patch)
2012-12-27 15:24 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (4.72 KB, patch)
2012-12-27 16:01 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (4.72 KB, patch)
2012-12-28 20:34 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-12-27 15:20:38 PST
[Texmap] Use a transform uniform instead of u_flip/u_textureSize
Comment 1 Noam Rosenthal 2012-12-27 15:24:18 PST
Created attachment 180826 [details]
Patch
Comment 2 Martin Robinson 2012-12-27 15:45:57 PST
Comment on attachment 180826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180826&action=review

Looks good to me, but I  have a couple questions.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:505
> +        patternTransform.setM22(-1);

Why not patternTransform.flipY() ?

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:176
> +            // Clamp in the shader, we can't rely on the texture wrap mode to clamp.
> +            vec4 clampedPosition = clamp(vec4(position, 0., 1.), 0., 1.);

Hrm. I don't really understand this bit of code...
Comment 3 Noam Rosenthal 2012-12-27 15:54:54 PST
(In reply to comment #2)
> (From update of attachment 180826 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180826&action=review
> 
> Looks good to me, but I  have a couple questions.
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:505
> > +        patternTransform.setM22(-1);
> 
> Why not patternTransform.flipY() ?

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:176
> > +            // Clamp in the shader, we can't rely on the texture wrap mode to clamp.
> > +            vec4 clampedPosition = clamp(vec4(position, 0., 1.), 0., 1.);
> 
> Hrm. I don't really understand this bit of code...
Comment 4 Noam Rosenthal 2012-12-27 16:01:06 PST
Created attachment 180828 [details]
Patch
Comment 5 Noam Rosenthal 2012-12-28 20:34:26 PST
Created attachment 180912 [details]
Patch
Comment 6 WebKit Review Bot 2012-12-28 21:11:37 PST
Comment on attachment 180912 [details]
Patch

Clearing flags on attachment: 180912

Committed r138556: <http://trac.webkit.org/changeset/138556>
Comment 7 WebKit Review Bot 2012-12-28 21:11:41 PST
All reviewed patches have been landed.  Closing bug.