Bug 105805 – [EFL][WebGL] Add GLES2 support in GraphicsContext3DEfl.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Kalyan]

Add OPENGL_ES_2 checks for relevant code in GraphicsContext3DPrivate, GraphicsContext3DEFl and GLPlatformContext classes.

[Kalyan]

Created attachment 180838 [details]
WIP

[Kalyan]

Created attachment 180840 [details]
patch

[Kalyan]

(In reply to comment #0)
> Add OPENGL_ES_2 checks for relevant code in GraphicsContext3DPrivate, GraphicsContext3DEFl and GLPlatformContext classes.

I will open another bug for changes in GLPlatformContext

[Noam Rosenthal]

Comment on attachment 180840 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180840&action=review

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:146
> -    bool enableScissorTest = false;
> -    int width = m_context->m_currentWidth;
> -    int height = m_context->m_currentHeight;
> -
> -    // We should copy the full buffer, and not respect the current scissor bounds.
> -    // FIXME: It would be more efficient to track the state of the scissor test.
> -    if (m_context->isEnabled(GraphicsContext3D::SCISSOR_TEST)) {
> -        enableScissorTest = true;
> -        m_context->disable(GraphicsContext3D::SCISSOR_TEST);
> -    }
> -
> +#if !USE(OPENGL_ES_2)
>      if (m_context->m_attrs.antialias) {
> +        bool enableScissorTest = false;

This looks sensible, but is not described in the ChangeLog.

[Kalyan]

changed bug title.

[Kalyan]

Created attachment 180848 [details]
patch

[Kalyan]

(In reply to comment #4)
> (From update of attachment 180840 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180840&action=review
> 
> > +#if !USE(OPENGL_ES_2)
> >      if (m_context->m_attrs.antialias) {
> > +        bool enableScissorTest = false;
> 
> This looks sensible, but is not described in the ChangeLog.

We could get rid of the ifdefs by using the extensions supported by GraphicsContext3D. The patch changes it so that GraphicsContext3DPrivate uses the framebufferblit extension supported by Extensions3D. Currently, we dont support antialiasing with GLES (i.e GraphicsContext3d::validateAttributes).

[Kenneth Rohde Christiansen]

Comment on attachment 180848 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180848&action=review

> Source/WebCore/ChangeLog:10
> +        This is in preparation for adding GLES2 support.
> +        This patch adds OPENGL_ES_2 checks in GraphicsContext3DEFl.
> +        With this patch, GraphicsContext3DPrivate uses the FramebufferBlit extension supported by Extensions3D.

pleae try to keep these lines a bit shorter... or at least the same length

[WebKit Review Bot]

Comment on attachment 180848 [details]
patch

Clearing flags on attachment: 180848

Committed r138526: <http://trac.webkit.org/changeset/138526>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.