Bug 105800 - Web Inspector: Native Memory Instrumentation. Update clang plugin according to current instrumentation state.
Summary: Web Inspector: Native Memory Instrumentation. Update clang plugin according t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-27 06:47 PST by Ilya Tikhonovsky
Modified: 2012-12-28 01:50 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.18 KB, patch)
2012-12-27 06:49 PST, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-12-27 06:47:16 PST 
The code of plugin is out of sync with current state of MemoryInstrumentation code.
Comment 1 Ilya Tikhonovsky 2012-12-27 06:49:07 PST 
Created attachment 180798 [details]
Patch
Comment 2 Yury Semikhatsky 2012-12-27 06:54:35 PST 
Comment on attachment 180798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180798&action=review

> Tools/clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:201
> +    "        info.addRawBuffer(m_pointer, m_length);\n"

You should also add m_length field.
Comment 3 Ilya Tikhonovsky 2012-12-28 01:50:43 PST 
Committed r138530: <http://trac.webkit.org/changeset/138530>