Bug 105798 - Web Inspector: move js heap snapshot preprocessing to JSHeapSnapshot
Summary: Web Inspector: move js heap snapshot preprocessing to JSHeapSnapshot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-27 05:17 PST by Yury Semikhatsky
Modified: 2012-12-27 07:58 PST (History)
9 users (show)

See Also:

Attachments
Patch (41.28 KB, patch)
2012-12-27 06:52 PST, Yury Semikhatsky 		pfeldman: review+
pfeldman: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-12-27 05:17:21 PST 
Methods like HeapSnapshot._markDetachedDOMTreeNodes should be moved to JSHeapSnapshot as they only make sense for JavaScript heap snapshots.
Comment 1 Yury Semikhatsky 2012-12-27 06:52:41 PST 
Created attachment 180799 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-12-27 06:57:06 PST 
Comment on attachment 180799 [details]
Patch

lgtm
Comment 3 Yury Semikhatsky 2012-12-27 07:58:31 PST 
Committed r138501: <http://trac.webkit.org/changeset/138501>