Bug 105795 - Web Inspector: [Network] Data grid header and content cells are misaligned.
Summary: Web Inspector: [Network] Data grid header and content cells are misaligned.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks: 105739
  Show dependency treegraph
 
Reported: 2012-12-27 04:30 PST by Eugene Klyuchnikov
Modified: 2013-01-09 22:30 PST (History)
9 users (show)

See Also:


Attachments
Screenshot, 3x zoom (8.32 KB, image/png)
2012-12-27 04:30 PST, Eugene Klyuchnikov
no flags Details
Patch (2.96 KB, patch)
2012-12-27 04:33 PST, Eugene Klyuchnikov
no flags Details | Formatted Diff | Diff
Patch (3.52 KB, patch)
2012-12-29 03:37 PST, Eugene Klyuchnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2012-12-27 04:30:11 PST
Created attachment 180789 [details]
Screenshot, 3x zoom

Header and content tables have different width.
Comment 1 Eugene Klyuchnikov 2012-12-27 04:33:44 PST
Created attachment 180790 [details]
Patch
Comment 2 Pavel Feldman 2012-12-28 02:54:02 PST
Comment on attachment 180790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review

> Source/WebCore/ChangeLog:8
> +        Header and content tables have different width -> same percent values

Why is this happening?
Comment 3 Pavel Feldman 2012-12-28 02:57:26 PST
Comment on attachment 180790 [details]
Patch

This was used for scroller.
Comment 4 Eugene Klyuchnikov 2012-12-28 23:46:25 PST
(In reply to comment #3)
> (From update of attachment 180790 [details])
> This was used for scroller.

Scroller is still there thanks to "overflow-y: overlay;" style.
Comment 5 Andrey Adaikin 2012-12-29 03:26:39 PST
Comment on attachment 180790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review

> Source/WebCore/inspector/front-end/DataGrid.js:137
> +    fillerRow.appendChild(cell);

instead of these 3 lines use:
  fillerRow.createChild("td", "corner");

> Source/WebCore/inspector/front-end/DataGrid.js:1077
> +        this._element.appendChild(cell);

ditto
Comment 6 Eugene Klyuchnikov 2012-12-29 03:36:22 PST
Comment on attachment 180790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review

>> Source/WebCore/ChangeLog:8
>> +        Header and content tables have different width -> same percent values
> 
> Why is this happening?

It was a hack to reserve place for scroller.

>> Source/WebCore/inspector/front-end/DataGrid.js:137
>> +    fillerRow.appendChild(cell);
> 
> instead of these 3 lines use:
>   fillerRow.createChild("td", "corner");

Done. Thanks.

>> Source/WebCore/inspector/front-end/DataGrid.js:1077
>> +        this._element.appendChild(cell);
> 
> ditto

Done.
Comment 7 Eugene Klyuchnikov 2012-12-29 03:37:25 PST
Created attachment 180931 [details]
Patch
Comment 8 WebKit Review Bot 2013-01-09 22:30:08 PST
Comment on attachment 180931 [details]
Patch

Clearing flags on attachment: 180931

Committed r139283: <http://trac.webkit.org/changeset/139283>
Comment 9 WebKit Review Bot 2013-01-09 22:30:11 PST
All reviewed patches have been landed.  Closing bug.