Bug 105782 - [TexMap] Minor refactoring of TextureMapperLayer.
Summary: [TexMap] Minor refactoring of TextureMapperLayer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-26 17:53 PST by Dongseong Hwang
Modified: 2012-12-27 18:19 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2012-12-26 17:54 PST, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-12-26 17:53:12 PST 
This patch has two refactorings.
1. Replace TextureMapperPaintOptions from header to implementation file.
2. Add non copyable property to TextureMapperLayer.
Comment 1 Dongseong Hwang 2012-12-26 17:54:40 PST 
Created attachment 180771 [details]
Patch
Comment 2 Darin Adler 2012-12-27 09:51:56 PST 
Comment on attachment 180771 [details]
Patch

OK
Comment 3 WebKit Review Bot 2012-12-27 09:58:16 PST 
Comment on attachment 180771 [details]
Patch

Clearing flags on attachment: 180771

Committed r138508: <http://trac.webkit.org/changeset/138508>
Comment 4 WebKit Review Bot 2012-12-27 09:58:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2012-12-27 10:08:43 PST 
One minor quibble. Marking a class as noncopyable is not a “refactoring” although it’s a sensible change to make here.
Comment 6 Dongseong Hwang 2012-12-27 18:19:53 PST 
(In reply to comment #5)
> One minor quibble. Marking a class as noncopyable is not a “refactoring” although it’s a sensible change to make here.

aha, you are right. I'll use more sensible word in next time :)