Bug 105781 - [TexMap] Remove m_size in TextureMapperLayer.
Summary: [TexMap] Remove m_size in TextureMapperLayer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks: 105760 105787
  Show dependency treegraph
 
Reported: 2012-12-26 17:41 PST by Dongseong Hwang
Modified: 2013-01-02 20:40 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.65 KB, patch)
2012-12-26 17:43 PST, Dongseong Hwang
dongseong.hwang: review+
dongseong.hwang: commit-queue-
Details | Formatted Diff | Diff
Patch (4.48 KB, patch)
2013-01-02 20:01 PST, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-12-26 17:41:10 PST
m_size is duplicated by State::size, so this patch removes it.
Comment 1 Dongseong Hwang 2012-12-26 17:43:22 PST
Created attachment 180770 [details]
Patch
Comment 2 Darin Adler 2012-12-27 09:50:58 PST
Comment on attachment 180770 [details]
Patch

Patch is not applying in the EWS. Please upload a new patch that does apply.
Comment 3 Noam Rosenthal 2013-01-01 12:34:07 PST
Comment on attachment 180770 [details]
Patch

Looks good but please rebase and go through EWS before committing.
Comment 4 Dongseong Hwang 2013-01-02 12:51:23 PST
(In reply to comment #3)
> (From update of attachment 180770 [details])
> Looks good but please rebase and go through EWS before committing.

Thanks for review :)

This bug depends on Bug 105760. 
Could you review Bug 105760.
After that, I'll rebase this bug.
Comment 5 Dongseong Hwang 2013-01-02 20:01:19 PST
Created attachment 181136 [details]
Patch
Comment 6 Dongseong Hwang 2013-01-02 20:02:27 PST
(In reply to comment #5)
> Created an attachment (id=181136) [details]
> Patch

Inverted dependency on Bug 105760 to land this bug firstly.
Comment 7 WebKit Review Bot 2013-01-02 20:40:19 PST
Comment on attachment 181136 [details]
Patch

Clearing flags on attachment: 181136

Committed r138695: <http://trac.webkit.org/changeset/138695>
Comment 8 WebKit Review Bot 2013-01-02 20:40:23 PST
All reviewed patches have been landed.  Closing bug.