Bug 105772 - [Mac] MemoryPressureHandler: Occasional crashes in uninstall() when responding to memory pressure signal.
Summary: [Mac] MemoryPressureHandler: Occasional crashes in uninstall() when respondin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-12-26 10:52 PST by Andreas Kling
Modified: 2012-12-28 18:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2012-12-26 11:01 PST, Andreas Kling 		slewis: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-12-26 10:52:06 PST 
I've seen a few null derefs in MemoryPressureHandler::uninstall() after sending synthetic memory pressure signals to WebKit. Looks like a race.
Comment 1 Andreas Kling 2012-12-26 11:01:32 PST 
Created attachment 180757 [details]
Patch
Comment 2 Stephanie Lewis 2012-12-26 11:16:57 PST 
Comment on attachment 180757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180757&action=review

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:89
> +        dispatch_source_cancel(_cache_event_source);

It might be a good idea to check if _cache_event_source is not null.
Comment 3 Andreas Kling 2012-12-26 12:14:44 PST 
Committed r138482: <http://trac.webkit.org/changeset/138482>
Comment 4 David Kilzer (:ddkilzer) 2012-12-28 18:17:11 PST 
<rdar://problem/12889515>