RESOLVED FIXED 105768
Web Inspector: extract JS heap profiler specifics into JSHeapSnapshot.js 
https://bugs.webkit.org/show_bug.cgi?id=105768
Summary Web Inspector: extract JS heap profiler specifics into JSHeapSnapshot.js
Yury Semikhatsky
Reported 2012-12-26 07:26:58 PST
HeapSnapshot.js can be split into a generic heap graph representation which can be reused for native heap and a JavaScript-specific part.
Attachments
Patch (48.67 KB, patch)
2012-12-26 07:30 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-12-26 07:30:15 PST
Created attachment 180747 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-12-26 07:38:38 PST
Comment on attachment 180747 [details] Patch lgtm with nits
Ilya Tikhonovsky
Comment 3 2012-12-26 07:41:06 PST
Comment on attachment 180747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180747&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:746 > + var node = this.createNode(0); please remove 0 > Source/WebCore/inspector/front-end/HeapSnapshot.js:892 > + var node = this.createNode(rootNodeIndex); rootNode() > LayoutTests/inspector/profiler/heap-snapshot.html:14 > + var nodeRoot = snapshot.createNode(snapshot._rootNodeIndex); rootNode > LayoutTests/inspector/profiler/heap-snapshot.html:28 > + var nodeRoot = snapshot.createNode(snapshot._rootNodeIndex); ditto
Yury Semikhatsky
Comment 4 2012-12-26 07:54:38 PST
(In reply to comment #3) > (From update of attachment 180747 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180747&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshot.js:746 > > + var node = this.createNode(0); > > please remove 0 > Done. > > Source/WebCore/inspector/front-end/HeapSnapshot.js:892 > > + var node = this.createNode(rootNodeIndex); > > rootNode() > I'd leave in the current state as we put rootNodeIndex into the array in the next line. > > LayoutTests/inspector/profiler/heap-snapshot.html:14 > > + var nodeRoot = snapshot.createNode(snapshot._rootNodeIndex); > > rootNode > There is no such method on the mock. > > LayoutTests/inspector/profiler/heap-snapshot.html:28 > > + var nodeRoot = snapshot.createNode(snapshot._rootNodeIndex); > > ditto There is no such method on the mock.
Yury Semikhatsky
Comment 5 2012-12-26 07:56:00 PST
Committed r138477: <http://trac.webkit.org/changeset/138477>
Note You need to log in before you can comment on or make changes to this bug.