Bug 105767 - Build fix for WinCE after r137709
Summary: Build fix for WinCE after r137709
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 104890
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-26 05:52 PST by Patrick R. Gansterer
Modified: 2013-03-01 02:51 PST (History)
9 users (show)

See Also:

Attachments
Patch (9.10 KB, patch)
2012-12-26 06:08 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (4.54 KB, patch)
2013-01-27 13:38 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-12-26 05:52:12 PST 
Build fix for WinCE after r137709
Comment 1 Patrick R. Gansterer 2012-12-26 06:08:40 PST 
Created attachment 180745 [details]
Patch
Comment 2 Filip Pizlo 2012-12-27 06:54:54 PST 
Comment on attachment 180745 [details]
Patch

Really, this is necessary?  That kind of defeats the purpose of trying to rationalize how binarySearch works. :-(  Is it absolutely clear that the WinCE compiler (presumably some variant of VS?) needs this much help, and is this far from C++ compliance?
Comment 3 Benjamin Poulain 2012-12-27 07:25:07 PST 
I am also curious to know what makes this template different?

Type resolution seems to work everywhere else.
Comment 4 Maciej Stachowiak 2013-01-18 23:03:25 PST 
What does the WinCE compiler complain about exactly? Is there another compiler that can be used?
Comment 5 Patrick R. Gansterer 2013-01-27 13:38:09 PST 
Created attachment 184923 [details]
Patch

(In reply to comment #2)
> Really, this is necessary?

It seems that I found a better solution for this in the new patch.

(In reply to comment #4)
> What does the WinCE compiler complain about exactly?

could not deduce template argument for 'overloaded function type' from 'overloaded function type'

> Is there another compiler that can be used?

No, this is the only compiler which produces production code for WinCE.
Comment 6 Patrick R. Gansterer 2013-01-29 08:21:20 PST 
ping?
Comment 7 Patrick R. Gansterer 2013-02-01 06:15:07 PST 
Committed r141586: <http://trac.webkit.org/changeset/141586>
Comment 8 Eric Seidel (no email) 2013-03-01 02:51:18 PST 
Comment on attachment 184923 [details]
Patch

Cleared review? from attachment 184923 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).