Bug 105764 – Web Inspector: Refactor SourceMapParser to enable range-based sourcemap

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Sass sourcemaps are semantically range-based rather than position-based (i.e. two sequential position mappings define a single range mapping, and positions between ranges are unmapped, that is, are mapped to themselves).

[Alexander Pavlov (apavlov)]

Created attachment 180742 [details]
Patch

[Build Bot]

Comment on attachment 180742 [details]
Patch

Attachment 180742 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15513971

New failing tests:
http/tests/inspector/compiler-script-mapping.html

[WebKit Review Bot]

Comment on attachment 180742 [details]
Patch

Attachment 180742 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15538005

New failing tests:
http/tests/inspector/compiler-script-mapping.html

[Alexander Pavlov (apavlov)]

Created attachment 180786 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 180786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180786&action=review

> Source/WebCore/inspector/front-end/SourceMap.js:60
> +        var result = [];

return Object.keys(this._sources);

> Source/WebCore/inspector/front-end/SourceMap.js:311
> +            if (map.sourceRoot)

We should do this only once in _parseMap

> Source/WebCore/inspector/front-end/SourceMap.js:340
> +            strippedMappings.push(this._mappings[i]);

this._mappings.filter(filterOut...)

> Source/WebCore/inspector/front-end/SourceMap.js:367
> +                if (nextEntry && nextEntry[0] === lineNumber && nextEntry[1] === columnNumber)

I would replace nextEntry check with index + 1 < this._mappings.length check before reading from the array.
also you can reuse comparator here.

> Source/WebCore/inspector/front-end/SourceMap.js:409
> +WebInspector.SourceRange = function(url, startLine, startColumn, endLine, endColumn)

I would call it WebInspector.RangeBasedSourceMap.SourceRange instead

[Alexander Pavlov (apavlov)]

Committed r138500: <http://trac.webkit.org/changeset/138500>