There are some implicit assumptions about the root node position etc which can be fixed to make HeapSnapshot.js more useful for native snapshots.
Created attachment 180739 [details] Patch
Comment on attachment 180739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180739&action=review otherwise lgtm > Source/WebCore/inspector/front-end/HeapSnapshot.js:1343 > + for (var nodeOrdinal = 0, l = this.nodeCount; nodeOrdinal < l; ++nodeOrdinal) { > + if (nodeOrdinal === rootNodeOrdinal) Please use the same logic here. We don't need additional if statement inside.
Created attachment 180740 [details] Patch
(In reply to comment #2) > Please use the same logic here. We don't need additional if statement inside. Done.
Comment on attachment 180740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180740&action=review > Source/WebCore/ChangeLog:8 > + HeapSnapshot.js now expects root node to be either the first or the last(real) one space between "last" and "(real)"?
(In reply to comment #5) > (From update of attachment 180740 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180740&action=review > > > Source/WebCore/ChangeLog:8 > > + HeapSnapshot.js now expects root node to be either the first or the last(real) one > > space between "last" and "(real)"? Done.
Committed r138475: <http://trac.webkit.org/changeset/138475>