Bug 105753 - [CMAKE] Remove header files in JavaScriptCore/CMakeLists.txt
Summary: [CMAKE] Remove header files in JavaScriptCore/CMakeLists.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-25 22:05 PST by Gyuyoung Kim
Modified: 2012-12-25 23:26 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2012-12-25 22:08 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (2.17 KB, patch)
2012-12-25 22:50 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-12-25 22:05:19 PST 
CMakeLists.txt includes header files in source list. CMake doesn't need to include them.
Comment 1 Gyuyoung Kim 2012-12-25 22:08:28 PST 
Created attachment 180727 [details]
Patch
Comment 2 Gyuyoung Kim 2012-12-25 22:10:01 PST 
CC'ing Laszlo, Patrick and Yong.
Comment 3 Laszlo Gombos 2012-12-25 22:20:11 PST 
Make sense, but I think there are more header files in the same file - e.g. profiler/ProfilerBytecode.h. Can you remove them all ?
Comment 4 Gyuyoung Kim 2012-12-25 22:50:31 PST 
Created attachment 180730 [details]
Patch
Comment 5 Gyuyoung Kim 2012-12-25 22:51:13 PST 
(In reply to comment #3)
> Make sense, but I think there are more header files in the same file - e.g. profiler/ProfilerBytecode.h. Can you remove them all ?

Ah, I missed some header files. Patch is updated.
Comment 6 Laszlo Gombos 2012-12-25 23:11:27 PST 
Comment on attachment 180730 [details]
Patch

r=me.
Comment 7 WebKit Review Bot 2012-12-25 23:25:57 PST 
Comment on attachment 180730 [details]
Patch

Clearing flags on attachment: 180730

Committed r138472: <http://trac.webkit.org/changeset/138472>
Comment 8 WebKit Review Bot 2012-12-25 23:26:02 PST 
All reviewed patches have been landed.  Closing bug.