Bug 105750 – All JIT stubs should go through the getCTIStub API

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Some of them are currently generated using the privateCompileCTITrampoline method.  That method is starting to get messy and has a lot of 8-way code duplication (link versus virtual, call versus construct, 32_64 versus 64).

Work in progress patch forthcoming.

[Filip Pizlo]

Created attachment 180723 [details]
work in progress

[Filip Pizlo]

Created attachment 180749 [details]
the patch

[WebKit Review Bot]

Attachment 180749 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/jit/ThunkGenerators.cpp:237:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/jit/ThunkGenerators.cpp:261:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/jit/ThunkGenerators.cpp:284:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/jit/ThunkGenerators.cpp:326:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 4 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

This appears to have set the bots on fire.

Before: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r138412%20(5567)/results.html
After: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r138413%20(5568)/results.html

Locally, I'm getting crashes on each test run.

[Filip Pizlo]

(In reply to comment #4)
> This appears to have set the bots on fire.
> 
> Before: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r138412%20(5567)/results.html
> After: http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r138413%20(5568)/results.html
> 
> Locally, I'm getting crashes on each test run.

Oh noes, I commented on the wrong bug. :-/

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/138516

[Csaba Osztrogonác]

(In reply to comment #6)
> Landed in http://trac.webkit.org/changeset/138516

It broke the MIPS, SH4 and the ARM build:

SH4 build log:
/local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp: In function ‘JSC::MacroAssemblerCodeRef JSC::nativeForGenerator(JSC::JSGlobalData*, JSC::CodeSpecializationKind)’:
/local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp:311:41: error: ‘regT5’ was not declared in this scope
/local/wkit/slavebuildbot/workspace/qt-linux-sh4-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp:384:12: error: ‘toCString’ was not declared in this scope


MIPS build log:
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp: In function 'JSC::MacroAssemblerCodeRef JSC::nativeForGenerator(JSC::JSGlobalData*, JSC::CodeSpecializationKind)':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp:384: error: 'toCString' was not declared in this scope


ARM build log:
/mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp: In function 'JSC::MacroAssemblerCodeRef JSC::nativeForGenerator(JSC::JSGlobalData*, JSC::CodeSpecializationKind)':
/mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/jit/ThunkGenerators.cpp:293:42: error: 'regT3' was not declared in this scope


Trivial fixes landed in:
- https://trac.webkit.org/changeset/138522
- https://trac.webkit.org/changeset/138523