Bug 105742 – Make the override-feature-defines script compatible with Python v3

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

Make the override-feature-defines script compatible with Python v3

[Zan Dobersek]

Created attachment 180713 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 180713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180713&action=review

> Tools/gtk/override-feature-defines:33
> +        print("The following feature defines were overriden:\n{0}".format(', '.join(overriden_feature_defines)))

Has the % operator been removed from py3?

[Zan Dobersek]

(In reply to comment #2)
> (From update of attachment 180713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180713&action=review
> 
> > Tools/gtk/override-feature-defines:33
> > +        print("The following feature defines were overriden:\n{0}".format(', '.join(overriden_feature_defines)))
> 
> Has the % operator been removed from py3?

Not yet, but there were plans to deprecate and eventually remove it[1]. The plans might have changed since then, though[2]. The Advances String Formatting[3], supported since Python 2.6, is recommended (especially in Python 3).


[1] http://docs.python.org/release/3.2.3/whatsnew/3.0.html#pep-3101-a-new-approach-to-string-formatting
[2] http://www.mail-archive.com/[e-mail]/msg35057.html
[3] http://www.python.org/dev/peps/pep-3101/

[Zan Dobersek]

Comment on attachment 180713 [details]
Patch

Clearing flags on attachment: 180713

Committed r139065: <http://trac.webkit.org/changeset/139065>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.