WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105736
[GTK][AC] Use new Clutter APIs instead of deprecated APIs
https://bugs.webkit.org/show_bug.cgi?id=105736
Summary
[GTK][AC] Use new Clutter APIs instead of deprecated APIs
Joone Hur
Reported
2012-12-24 22:06:01 PST
ClutterCairoTexture class and the following functions have been deprecated since version 1.10 * clutter_actor_show_all, clutter_stage_set_color, clutter_container_add_actor
Attachments
Patch
(12.65 KB, patch)
2012-12-24 22:43 PST
,
Joone Hur
no flags
Details
Formatted Diff
Diff
Patch
(12.78 KB, patch)
2012-12-24 22:59 PST
,
Joone Hur
gustavo
: review+
Details
Formatted Diff
Diff
Patch
(12.79 KB, patch)
2013-01-25 17:49 PST
,
Joone Hur
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Joone Hur
Comment 1
2012-12-24 22:43:22 PST
Created
attachment 180700
[details]
Patch
Joone Hur
Comment 2
2012-12-24 22:59:17 PST
Created
attachment 180702
[details]
Patch
ChangSeok Oh
Comment 3
2013-01-08 06:49:33 PST
***
Bug 106173
has been marked as a duplicate of this bug. ***
Gustavo Noronha (kov)
Comment 4
2013-01-21 10:31:07 PST
Comment on
attachment 180702
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=180702&action=review
LGTM with nit about comment.
> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:314 > + // the actor now owns the canvas
This is not a full sentence, but the comment is not very useful anyway, so I'd just remove it.
Joone Hur
Comment 5
2013-01-25 17:49:16 PST
Created
attachment 184846
[details]
Patch
Joone Hur
Comment 6
2013-01-25 17:50:29 PST
Comment on
attachment 184846
[details]
Patch Kov,thanks for the review!
WebKit Review Bot
Comment 7
2013-01-25 18:12:57 PST
Comment on
attachment 184846
[details]
Patch Clearing flags on attachment: 184846 Committed
r140896
: <
http://trac.webkit.org/changeset/140896
>
Gustavo Noronha (kov)
Comment 8
2013-02-26 07:23:22 PST
Have you tested this code, does it work for you? After I merged this into webkit-clutter It doesn't seem to render the layer contents properly, reverting back to using the Texture makes it go back to working for me.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug