Bug 105728 - [BlackBerry] Update BB10 media render theme.
Summary: [BlackBerry] Update BB10 media render theme.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-24 10:40 PST by Tiancheng Jiang
Modified: 2013-01-03 09:33 PST (History)
13 users (show)

See Also:


Attachments
Patch (4.02 KB, patch)
2012-12-24 11:18 PST, Tiancheng Jiang
no flags Details | Formatted Diff | Diff
Patch (6.64 KB, patch)
2013-01-02 13:53 PST, Tiancheng Jiang
no flags Details | Formatted Diff | Diff
Patch (6.78 KB, patch)
2013-01-02 14:59 PST, Tiancheng Jiang
no flags Details | Formatted Diff | Diff
Patch (6.79 KB, patch)
2013-01-03 07:56 PST, Tiancheng Jiang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tiancheng Jiang 2012-12-24 10:40:48 PST
Update media theme using GL friendly method and meet new UX specs.
Comment 1 Tiancheng Jiang 2012-12-24 11:18:31 PST
Created attachment 180684 [details]
Patch
Comment 2 Rob Buis 2012-12-24 11:23:18 PST
Comment on attachment 180684 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-12-24 11:38:58 PST
Comment on attachment 180684 [details]
Patch

Clearing flags on attachment: 180684

Committed r138447: <http://trac.webkit.org/changeset/138447>
Comment 4 WebKit Review Bot 2012-12-24 11:39:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Tiancheng Jiang 2013-01-02 13:53:23 PST
Reopening to attach new patch.
Comment 6 Tiancheng Jiang 2013-01-02 13:53:26 PST
Created attachment 181059 [details]
Patch
Comment 7 Yong Li 2013-01-02 14:06:14 PST
Comment on attachment 181059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181059&action=review

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1094
> +    static Image* mediaSliderThumb;
> +    if (!isEnabled(object))
> +        mediaSliderThumb = Image::loadPlatformResource("core_slider_handle_disabled").leakRef();
> +    else {
> +        if (isPressed(object) || isHovered(object) || isFocused(object))
> +            mediaSliderThumb = Image::loadPlatformResource("core_slider_handle_pressed").leakRef();
> +        else
> +            mediaSliderThumb = Image::loadPlatformResource("core_media_handle").leakRef();
> +    }

will this leak an image every time? I would use 3 static Image* objects that are initialized upon first time, and then reused.
Comment 8 Yong Li 2013-01-02 14:09:30 PST
Comment on attachment 181059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181059&action=review

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1135
> +    static Image* volumeBar = Image::loadPlatformResource("core_slider_played_bg").leakRef();
> +    // This is to paint main volume slider bar.

A space between 1134 and 1135 would be neat.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1140
> +    bool result = paintSliderTrackRect(object, paintInfo, rect2, volumeBackground);
> +
> +    if (volume > 0) {
> +        // This is to paint volume bar (left of volume slider thumb) using selection color.
> +        paintSliderTrackRect(object, paintInfo, volumeRect, volumeBar);

I'm confused here. should it be

result |= paintSliderTrackRect(object, paintInfo, volumeRect, volumeBar);
Comment 9 Tiancheng Jiang 2013-01-02 14:59:13 PST
Created attachment 181075 [details]
Patch
Comment 10 Yong Li 2013-01-02 15:09:54 PST
Comment on attachment 181075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181075&action=review

LGTM. But it doesn't apply to webkit ToT? You may want John to review it again.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1089
>      static Image* mediaSliderThumb = Image::loadPlatformResource("core_media_handle").leakRef();
> -
> +    if (!isEnabled(object))

minor: a space here would be nice.
Comment 11 John Griggs 2013-01-03 07:50:41 PST
Comment on attachment 181075 [details]
Patch

Looks good to me
Comment 12 John Griggs 2013-01-03 07:51:08 PST
R+ from me as well.
Comment 13 Tiancheng Jiang 2013-01-03 07:56:40 PST
Created attachment 181176 [details]
Patch
Comment 14 WebKit Review Bot 2013-01-03 08:25:54 PST
Comment on attachment 181176 [details]
Patch

Rejecting attachment 181176 [details] from commit-queue.

tijiang@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 15 WebKit Review Bot 2013-01-03 09:05:12 PST
Comment on attachment 181176 [details]
Patch

Attachment 181176 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15647746

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 16 WebKit Review Bot 2013-01-03 09:33:47 PST
Comment on attachment 181176 [details]
Patch

Clearing flags on attachment: 181176

Committed r138712: <http://trac.webkit.org/changeset/138712>
Comment 17 WebKit Review Bot 2013-01-03 09:33:51 PST
All reviewed patches have been landed.  Closing bug.