Bug 105722 – Web Inspector: Make InspectorState instances per-agent, corresponding to JSON map entries in the cookie

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

The blamed line is InspectorState.cpp:136

Patch to follow.

[Yury Semikhatsky]

(In reply to comment #0)
> The blamed line is InspectorState.cpp:136
> 
> Patch to follow.

Could you provide more details or at least link to the corresponding revision where the line 136 would fail as on the current tot r138449 InspectorState.cpp is only 131 line long?

[Alexander Pavlov (apavlov)]

(In reply to comment #1)
> (In reply to comment #0)
> > The blamed line is InspectorState.cpp:136
> > 
> > Patch to follow.
> 
> Could you provide more details or at least link to the corresponding revision where the line 136 would fail as on the current tot r138449 InspectorState.cpp is only 131 line long?

As agreed with pfeldman, the offending change r138436 was reverted, as the composite state should be implemented in a slightly different way.

[Alexander Pavlov (apavlov)]

Created attachment 180703 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 180703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180703&action=review

> Source/WebCore/inspector/InspectorState.cpp:137
> +        if (!agentStateObject) {

When can this happen? Also if some agent states may be missing there might be some extra states which we probably want to delete?

[Alexander Pavlov (apavlov)]

(In reply to comment #4)
> (From update of attachment 180703 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180703&action=review
> 
> > Source/WebCore/inspector/InspectorState.cpp:137
> > +        if (!agentStateObject) {
> 
> When can this happen?

This can happen if a cookie was written before all InspectorStates had been constructed.

> Also if some agent states may be missing there might be some extra states which we probably want to delete?

This means that the respective state is empty, which we handle by creating an empty object to pass into InspectorState::setFromCookie().

[WebKit Review Bot]

Comment on attachment 180703 [details]
Patch

Clearing flags on attachment: 180703

Committed r138457: <http://trac.webkit.org/changeset/138457>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexander Pavlov (apavlov)]

*** Bug 105438 has been marked as a duplicate of this bug. ***