105703 – Switch WebCookieManager and AuthenticationManager to use the ChildProcess rather than holding on to a Connection

Bug 105703 - Switch WebCookieManager and AuthenticationManager to use the ChildProcess rather than holding on to a Connection

Summary: Switch WebCookieManager and AuthenticationManager to use the ChildProcess rat...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Sam Weinig

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-12-23 19:31 PST by Sam Weinig
Modified:	2012-12-24 00:21 PST (History)
CC List:	8 users (show)

See Also:

Attachments
Patch (16.91 KB, patch) 2012-12-23 19:37 PST, Sam Weinig	no flags	Details \| Formatted Diff \| Diff
Patch (18.66 KB, patch) 2012-12-23 20:10 PST, Sam Weinig	mitz: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Weinig 2012-12-23 19:31:28 PST

Switch WebCookieManager and AuthenticationManager to use the ChildProcess rather than holding on to a Connection

Comment 1 Sam Weinig 2012-12-23 19:37:52 PST

Created attachment 180634 [details]
Patch

Comment 2 WebKit Review Bot 2012-12-23 19:40:48 PST

Attachment 180634 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/Cookies/WebCookieManager.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Build Bot 2012-12-23 19:45:00 PST

Comment on attachment 180634 [details]
Patch

Attachment 180634 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15508264

Comment 4 Early Warning System Bot 2012-12-23 19:45:43 PST

Comment on attachment 180634 [details]
Patch

Attachment 180634 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15503265

Comment 5 EFL EWS Bot 2012-12-23 19:49:26 PST

Comment on attachment 180634 [details]
Patch

Attachment 180634 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15498296

Comment 6 kov's GTK+ EWS bot 2012-12-23 19:56:20 PST

Comment on attachment 180634 [details]
Patch

Attachment 180634 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15498298

Comment 7 Sam Weinig 2012-12-23 20:10:18 PST

Created attachment 180638 [details]
Patch

Comment 8 Sam Weinig 2012-12-23 21:46:05 PST

Committed r138433: <http://trac.webkit.org/changeset/138433>

Comment 9 Csaba Osztrogonác 2012-12-24 00:17:15 PST

(In reply to comment #8)
> Committed r138433: <http://trac.webkit.org/changeset/138433>

It broke the Qt-Windows build:
c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\cookies\WebCookieManager.h(53) : error C2061: syntax error : identifier 'uint64_t'
c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\cookies\WebCookieManager.h(58) : error C2061: syntax error : identifier 'uint64_t'
C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\WebProcess\Cookies\WebCookieManager.cpp(61) : error C2511: 'void WebKit::WebCookieManager::getHostnamesWithCookies(uint64_t)' : overloaded member function not found in 'WebKit::WebCookieManager'
        c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\cookies\WebCookieManager.h(42) : see declaration of 'WebKit::WebCookieManager'
C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\WebProcess\Cookies\WebCookieManager.cpp(108) : error C2511: 'void WebKit::WebCookieManager::getHTTPCookieAcceptPolicy(uint64_t)' : overloaded member function not found in 'WebKit::WebCookieManager'
        c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\cookies\WebCookieManager.h(42) : see declaration of 'WebKit::WebCookieManager'

Comment 10 Csaba Osztrogonác 2012-12-24 00:21:04 PST

Speculative buildfix landed in https://trac.webkit.org/changeset/138435.