Bug 105700 - Remove more special cased message receiving code from WebProcess
Summary: Remove more special cased message receiving code from WebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 105712
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-23 17:21 PST by Sam Weinig
Modified: 2012-12-24 11:07 PST (History)
2 users (show)

See Also:

Attachments
Patch (26.21 KB, patch)
2012-12-23 17:22 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-12-23 17:21:52 PST 
Remove more special cased message receiving code from WebProcess
Comment 1 Sam Weinig 2012-12-23 17:22:45 PST 
Created attachment 180632 [details]
Patch
Comment 2 mitz 2012-12-23 18:30:45 PST 
Comment on attachment 180632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180632&action=review

> Source/WebKit2/WebProcess/WebProcess.h:192
> +    // Database
> +    WebDatabaseManager& databaseManager() { return m_databaseManager; }

Shouldn’t this be guarded by #if ENABLE(SQL_DATABASE)?
Comment 3 Sam Weinig 2012-12-23 18:35:54 PST 
Committed r138428: <http://trac.webkit.org/changeset/138428>
Comment 4 Csaba Osztrogonác 2012-12-24 00:15:45 PST 
(In reply to comment #3)
> Committed r138428: <http://trac.webkit.org/changeset/138428>

It made all tests crash everywhere:
- Qt-WK2 bot: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/12055
- EFL WK2 bot: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/2068
- GTK WK2 bot: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/builds/3739

I don't know anything about the Apple Mac WK bots, because they are very sick:
- Apple Lion Release WK2 (Tests) - offline
- Apple Lion Debug WK2 (Tests) - tests fails on it from 21st Dec
- Apple MountainLion Debug WK2 (Tests) - fails with "Retry exception slave lost"
- Apple MountainLion Release WK2 (Tests) - fails with "Retry exception slave lost"

Could you fix it please as soon as possible? It won't be good to leave the tree broken for the whole Christmas holiday.
Comment 5 WebKit Review Bot 2012-12-24 00:32:44 PST 
Re-opened since this is blocked by bug 105712
Comment 6 Csaba Osztrogonác 2012-12-24 00:38:18 PST 
(In reply to comment #5)
> Re-opened since this is blocked by bug 105712

I'm going to rollout r138428, r138429 (buildfix for r138428) and the following patches, because they are in conflict with it: r138433, r138435 (buildfix for r138433) if you can't fix the breaking soon.
Comment 7 Sam Weinig 2012-12-24 11:07:33 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > Re-opened since this is blocked by bug 105712
> 
> I'm going to rollout r138428, r138429 (buildfix for r138428) and the following patches, because they are in conflict with it: r138433, r138435 (buildfix for r138433) if you can't fix the breaking soon.

This should be fixed now.