Bug 105700 – Remove more special cased message receiving code from WebProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Remove more special cased message receiving code from WebProcess

[Sam Weinig]

Created attachment 180632 [details]
Patch

Comment on attachment 180632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180632&action=review

> Source/WebKit2/WebProcess/WebProcess.h:192
> +    // Database
> +    WebDatabaseManager& databaseManager() { return m_databaseManager; }

Shouldn’t this be guarded by #if ENABLE(SQL_DATABASE)?

[Sam Weinig]

Committed r138428: <http://trac.webkit.org/changeset/138428>

[Csaba Osztrogonác]

(In reply to comment #3)
> Committed r138428: <http://trac.webkit.org/changeset/138428>

It made all tests crash everywhere:
- Qt-WK2 bot: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/12055
- EFL WK2 bot: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/2068
- GTK WK2 bot: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/builds/3739

I don't know anything about the Apple Mac WK bots, because they are very sick:
- Apple Lion Release WK2 (Tests) - offline
- Apple Lion Debug WK2 (Tests) - tests fails on it from 21st Dec
- Apple MountainLion Debug WK2 (Tests) - fails with "Retry exception slave lost"
- Apple MountainLion Release WK2 (Tests) - fails with "Retry exception slave lost"

Could you fix it please as soon as possible? It won't be good to leave the tree broken for the whole Christmas holiday.

[WebKit Review Bot]

Re-opened since this is blocked by bug 105712

[Csaba Osztrogonác]

(In reply to comment #5)
> Re-opened since this is blocked by bug 105712

I'm going to rollout r138428, r138429 (buildfix for r138428) and the following patches, because they are in conflict with it: r138433, r138435 (buildfix for r138433) if you can't fix the breaking soon.

[Sam Weinig]

(In reply to comment #6)
> (In reply to comment #5)
> > Re-opened since this is blocked by bug 105712
> 
> I'm going to rollout r138428, r138429 (buildfix for r138428) and the following patches, because they are in conflict with it: r138433, r138435 (buildfix for r138433) if you can't fix the breaking soon.

This should be fixed now.