105696 – JITThunks should not compile only because of luck

RESOLVED FIXED 105696

JITThunks should not compile only because of luck

https://bugs.webkit.org/show_bug.cgi?id=105696

Summary JITThunks should not compile only because of luck

Filip Pizlo

Reported 2012-12-23 12:28:52 PST

Patch forthcoming.

Attachments
the patch (141.96 KB, patch) 2012-12-23 12:34 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
another attempt (184.79 KB, patch) 2012-12-23 13:12 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
patch for landing (201.01 KB, patch) 2012-12-23 21:25 PST, Filip Pizlo	webkit-ews: commit-queue-	Details Formatted Diff Diff
patch for landing (201.42 KB, patch) 2012-12-24 10:21 PST, Filip Pizlo	eflews.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (201.85 KB, patch) 2012-12-24 12:09 PST, Filip Pizlo	eflews.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (206.90 KB, patch) 2012-12-24 13:26 PST, Filip Pizlo	eflews.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (209.58 KB, patch) 2012-12-24 14:02 PST, Filip Pizlo	eflews.bot: commit-queue-	Details Formatted Diff Diff
trying to touch Platform.h (210.07 KB, patch) 2012-12-24 14:26 PST, Filip Pizlo	webkit-ews: commit-queue-	Details Formatted Diff Diff
trying more things (210.42 KB, patch) 2012-12-24 19:28 PST, Filip Pizlo	webkit-ews: commit-queue-	Details Formatted Diff Diff
patch for landing (168.34 KB, patch) 2013-01-10 14:31 PST, Filip Pizlo	webkit-ews: commit-queue-	Details Formatted Diff Diff
patch for landing (169.49 KB, patch) 2013-01-11 13:31 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-12-23 12:34:40 PST

Created attachment 180628 [details] the patch This will probably still have random build errors. I'm still checking if I need to add #include Operations.h into WebCore and elsewhere.

Sam Weinig

Comment 2 2012-12-23 12:37:49 PST

Comment on attachment 180628 [details] the patch rs=me

WebKit Review Bot

Comment 3 2012-12-23 12:38:42 PST

Attachment 180628 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1 Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:337: The parameter name "plan" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:338: The parameter name "plan" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 56 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 4 2012-12-23 12:42:23 PST

Comment on attachment 180628 [details] the patch Attachment 180628 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15492228

Early Warning System Bot

Comment 5 2012-12-23 12:42:35 PST

Comment on attachment 180628 [details] the patch Attachment 180628 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15492224

EFL EWS Bot

Comment 6 2012-12-23 12:44:23 PST

Comment on attachment 180628 [details] the patch Attachment 180628 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15513025

Filip Pizlo

Comment 7 2012-12-23 13:12:29 PST

Created attachment 180629 [details] another attempt I think I still have a lot of work to do adding #include "Operations.h" in WebCore.

Filip Pizlo

Comment 8 2012-12-23 21:25:14 PST

Created attachment 180641 [details] patch for landing Hopefully this will make all of the things happy.

WebKit Review Bot

Comment 9 2012-12-23 21:28:33 PST

Attachment 180641 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/RegExpCachedResult.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/SmallStrings.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:36: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 164 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 10 2012-12-23 21:37:04 PST

Comment on attachment 180641 [details] patch for landing Attachment 180641 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15503295

Early Warning System Bot

Comment 11 2012-12-23 21:39:19 PST

Comment on attachment 180641 [details] patch for landing Attachment 180641 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15498328

EFL EWS Bot

Comment 12 2012-12-23 22:13:36 PST

Comment on attachment 180641 [details] patch for landing Attachment 180641 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15511197

Filip Pizlo

Comment 13 2012-12-24 10:21:40 PST

Created attachment 180679 [details] patch for landing Try to fix Qt build. Hopefully it also fixes EFL build.

WebKit Review Bot

Comment 14 2012-12-24 10:24:47 PST

Attachment 180679 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/RegExpCachedResult.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/SmallStrings.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:36: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 165 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 15 2012-12-24 11:59:34 PST

Comment on attachment 180679 [details] patch for landing Attachment 180679 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15507533

EFL EWS Bot

Comment 16 2012-12-24 12:04:03 PST

Comment on attachment 180679 [details] patch for landing Attachment 180679 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15512476

Filip Pizlo

Comment 17 2012-12-24 12:09:02 PST

Created attachment 180685 [details] patch for landing

WebKit Review Bot

Comment 18 2012-12-24 12:13:09 PST

Attachment 180685 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 166 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 19 2012-12-24 12:38:29 PST

Comment on attachment 180685 [details] patch for landing Attachment 180685 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15491629

Filip Pizlo

Comment 20 2012-12-24 13:26:36 PST

Created attachment 180689 [details] patch for landing And try again.

WebKit Review Bot

Comment 21 2012-12-24 13:29:28 PST

Attachment 180689 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 178 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 22 2012-12-24 13:39:19 PST

Comment on attachment 180689 [details] patch for landing Attachment 180689 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15492607

Filip Pizlo

Comment 23 2012-12-24 14:02:53 PST

Created attachment 180690 [details] patch for landing Trying again.

WebKit Review Bot

Comment 24 2012-12-24 14:07:12 PST

Attachment 180690 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 184 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 25 2012-12-24 14:14:23 PST

Comment on attachment 180690 [details] patch for landing Attachment 180690 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15527125

Filip Pizlo

Comment 26 2012-12-24 14:26:57 PST

Created attachment 180691 [details] trying to touch Platform.h Trying to see if the build error is due to EFL's build system not doing dependencies correctly.

WebKit Review Bot

Comment 27 2012-12-24 14:30:31 PST

Attachment 180691 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 185 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 28 2012-12-24 14:40:13 PST

Comment on attachment 180691 [details] trying to touch Platform.h Attachment 180691 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15495588

Early Warning System Bot

Comment 29 2012-12-24 14:43:51 PST

Comment on attachment 180691 [details] trying to touch Platform.h Attachment 180691 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15496609

EFL EWS Bot

Comment 30 2012-12-24 15:05:59 PST

Comment on attachment 180691 [details] trying to touch Platform.h Attachment 180691 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15490715

Filip Pizlo

Comment 31 2012-12-24 19:28:09 PST

Created attachment 180696 [details] trying more things

WebKit Review Bot

Comment 32 2012-12-24 19:32:55 PST

Attachment 180696 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 186 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 33 2012-12-24 19:41:42 PST

Comment on attachment 180696 [details] trying more things Attachment 180696 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15497652

Early Warning System Bot

Comment 34 2012-12-24 19:44:32 PST

Comment on attachment 180696 [details] trying more things Attachment 180696 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15496679

EFL EWS Bot

Comment 35 2012-12-24 20:01:09 PST

Comment on attachment 180696 [details] trying more things Attachment 180696 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15492693

Chris Dumez

Comment 36 2012-12-25 00:07:37 PST

FYI, the patch is building just fine on my machine for EFL port (despite the EWS saying otherwise). It probably just requires a clean build?

Gyuyoung Kim

Comment 37 2012-12-25 20:05:38 PST

(In reply to comment #36) > FYI, the patch is building just fine on my machine for EFL port (despite the EWS saying otherwise). It probably just requires a clean build? Hmm, there are still linking errors on my PC though I build this patch from scratch. Linking CXX executable ../../../bin/jsc ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSValue::isGetterSetter() const' ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSValue::JSValue(JSC::JSCell*)' ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSValue::asCell() const' ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSValue::decode(long)' ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSCell::structure() const' collect2: ld returned 1 exit status make[2]: *** [bin/jsc] Error 1 make[1]: *** [Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/all] Error 2

Csaba Osztrogonác

Comment 38 2012-12-27 06:48:39 PST

(In reply to comment #34) > (From update of attachment 180696 [details]) > Attachment 180696 [details] did not pass qt-wk2-ews (qt): > Output: http://queues.webkit.org/results/15496679 There are many conflicts and I can't apply the patch on ToT: Source/JavaScriptCore/CMakeLists.txt Source/JavaScriptCore/GNUmakefile.list.am Source/JavaScriptCore/Target.pri Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj Source/JavaScriptCore/jit/JITStubs.cpp Let's see an earlier revision - r138446. The build failed for me as the EWS said. I tracked down in which objects are these missing symbols an then I added #include "Operations.h" to the following files and now Qt build is happy on r138446: - ErrorInstance.cpp - NameInstance.cpp - JSVariableObject.cpp

Eric Seidel (no email)

Comment 39 2013-01-04 00:41:20 PST

Comment on attachment 180628 [details] the patch Cleared Sam Weinig's review+ from obsolete attachment 180628 [details] so that this bug does not appear in http://webkit.org/pending-commit.

Filip Pizlo

Comment 40 2013-01-10 14:31:43 PST

Created attachment 182210 [details] patch for landing

WebKit Review Bot

Comment 41 2013-01-10 14:43:50 PST

Attachment 182210 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 178 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 42 2013-01-10 14:45:17 PST

Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15806116

Early Warning System Bot

Comment 43 2013-01-10 14:46:52 PST

Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15809079

Build Bot

Comment 44 2013-01-10 14:56:12 PST

Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15806117

Build Bot

Comment 45 2013-01-10 15:17:06 PST

Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15775910

WebKit Review Bot

Comment 46 2013-01-10 15:44:53 PST

Early Warning System Bot

Comment 47 2013-01-10 15:46:05 PST

Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15795388

Early Warning System Bot

Comment 48 2013-01-10 15:50:15 PST

Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15811051

EFL EWS Bot

Comment 49 2013-01-10 16:47:29 PST

Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15803142

EFL EWS Bot

Comment 50 2013-01-10 17:03:00 PST

Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15805138

Filip Pizlo

Comment 51 2013-01-11 13:31:41 PST

Created attachment 182406 [details] patch for landing

WebKit Review Bot

Comment 52 2013-01-11 13:34:15 PST

Attachment 182406 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 181 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 53 2013-01-11 20:51:10 PST

Landed in http://trac.webkit.org/changeset/139541

Filip Pizlo

Comment 54 2013-01-11 20:56:06 PST

Fixed changelogs in http://trac.webkit.org/changeset/139542

Csaba Osztrogonác

Comment 55 2013-02-08 05:42:17 PST

(In reply to comment #53) > Landed in http://trac.webkit.org/changeset/139541 After this one https://trac.webkit.org/changeset/141185/trunk/Source/JavaScriptCore/runtime/JSGlobalData.h fixed the !ENABLE_JIT build.

Csaba Osztrogonác

Comment 56 2013-02-11 10:18:43 PST

(In reply to comment #53) > Landed in http://trac.webkit.org/changeset/139541 One more buildfix for !ENABLE(JIT) case - http://trac.webkit.org/changeset/142489

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component JavaScriptCore

Assignee

Filip Pizlo

Reported

2012-12-23 12:28 PST

Modified

2013-02-11 10:18 PST History

CC List

19 users Show

URL

Keywords

Depends on

105744

Blocks

Dependencies

tree graph