We should rename WKViewGetSnapshot to WKViewCreateSnapshot since the returned value needs to be adopted. The snapshot taking code should also be refactored to use smart pointers when possible.
Created attachment 180619 [details] Patch
Comment on attachment 180619 [details] Patch I think we can simplify a bit more, clearing flags for now.
(In reply to comment #2) > (From update of attachment 180619 [details]) > I think we can simplify a bit more, clearing flags for now. Nevermind, I think this is good enough for now. The patch is ready for review.
Comment on attachment 180619 [details] Patch Actually, we can remove the call to glBindTexture() before glReadPixels(). It is not needed as glReadPixels() reads from the frame buffer, not the texture.
Created attachment 180663 [details] Patch
Comment on attachment 180663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180663&action=review > Source/WebKit2/ChangeLog:21 > + a cairo_surface_t instead of a WKType. The value should be > + converted to a WKType a C API level. at*
Comment on attachment 180663 [details] Patch Rejecting attachment 180663 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue ChangeLog entry in Tools/ChangeLog is not at the top of the file. Full output: http://queues.webkit.org/results/15503681
Created attachment 180706 [details] Patch for landing
Comment on attachment 180706 [details] Patch for landing Clearing flags on attachment: 180706 Committed r138462: <http://trac.webkit.org/changeset/138462>
All reviewed patches have been landed. Closing bug.