Bug 105684 – [WK2] Network process should respect cookie accept policy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alexey Proskuryakov]

Changing cookie accept policy works in normal browsing mode, because the cookie storage is shared across all processes. It does not however affect private browsing cookie storage.

<rdar://problem/12808377>

[Alexey Proskuryakov]

Created attachment 180614 [details]
proposed patch

One part I'm not quite sure about is handling WebCookieManagerProxy messages from NetworkProcess. But it seems reasonable to have the code match WebProcess.

[WebKit Review Bot]

Attachment 180614 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/NetworkProcess/NetworkProce..." exit_code: 1
Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:63:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp:86:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 180614 [details]
proposed patch

Attachment 180614 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15452987

[Early Warning System Bot]

Comment on attachment 180614 [details]
proposed patch

Attachment 180614 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15456969

[Alexey Proskuryakov]

Created attachment 180615 [details]
with non-NetworkProcess build fixes

[EFL EWS Bot]

Comment on attachment 180615 [details]
with non-NetworkProcess build fixes

Attachment 180615 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15490108

[Early Warning System Bot]

Comment on attachment 180615 [details]
with non-NetworkProcess build fixes

Attachment 180615 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15458966

[kov's GTK+ EWS bot]

Comment on attachment 180615 [details]
with non-NetworkProcess build fixes

Attachment 180615 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15456975

[Alexey Proskuryakov]

Created attachment 180616 [details]
more build fixes

[WebKit Review Bot]

Comment on attachment 180616 [details]
more build fixes

Attachment 180616 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15495019

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Alexey Proskuryakov]

The failing chromium test can't be related. This is ready for review.

[Sam Weinig]

Comment on attachment 180616 [details]
more build fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=180616&action=review

> Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:117
> +    if (m_webContext->dispatchMessage(connection, messageID, decoder))
> +        return;

Instead of doing this, the WebContext should be registered as a message receiver in the messageReceiverMap.

[Sam Weinig]

(In reply to comment #12)
> (From update of attachment 180616 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180616&action=review
> 
> > Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:117
> > +    if (m_webContext->dispatchMessage(connection, messageID, decoder))
> > +        return;
> 
> Instead of doing this, the WebContext should be registered as a message receiver in the messageReceiverMap.

Um, nevermind. That won't work.  Carry on.

[WebKit Review Bot]

Comment on attachment 180616 [details]
more build fixes

Clearing flags on attachment: 180616

Committed r138427: <http://trac.webkit.org/changeset/138427>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.