Bug 105682 - Make CustomProtocolManager a MessageReceiver to remove more special casing
Summary: Make CustomProtocolManager a MessageReceiver to remove more special casing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-22 19:20 PST by Sam Weinig
Modified: 2012-12-23 13:04 PST (History)
0 users

See Also:

Attachments
Patch (15.32 KB, patch)
2012-12-22 19:31 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-12-22 19:20:23 PST 
Make CustomProtocolManager a MessageReceiver to remove more special casing
Comment 1 Sam Weinig 2012-12-22 19:31:27 PST 
Created attachment 180612 [details]
Patch
Comment 2 mitz 2012-12-23 12:29:47 PST 
Comment on attachment 180612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180612&action=review

> Source/WebKit2/ChangeLog:22
> +        Call connectionEstablished on the CustomProtocolManager to make start working as a NSURLProtocol handler.

Missing word!

> Source/WebKit2/ChangeLog:35
> +        (WebKit):

WebKit?

> Source/WebKit2/ChangeLog:42
> +        (WebKit):

WebKit??

> Source/WebKit2/ChangeLog:46
> +        Make CustomProtocolManager a MessageReceiver and split initialization and
> +        from the time when it can start acting as protocol handler as these happen at

initialization and what?

> Source/WebKit2/ChangeLog:61
> +        Call connectionEstablished on the CustomProtocolManager to make start working as a NSURLProtocol handler.

$ make start
make: *** No rule to make target `start'.  Stop.
Comment 3 Sam Weinig 2012-12-23 13:04:19 PST 
Committed r138426: <http://trac.webkit.org/changeset/138426>