According to WebKit coding style - "All implementation files must #include "config.h" first. Header files should never include "config.h" As config.h (by design) includes wtf/Platform.h including wtf/Platform.h explicitly in {c|cpp} files is always a duplicate/unnecessary.
Created attachment 180606 [details] proposed change If this patch lands, I plan to file a separate bug to add this rule to check-webkit-style.
Comment on attachment 180606 [details] proposed change OK
Comment on attachment 180606 [details] proposed change Rejecting attachment 180606 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15503556
Comment on attachment 180606 [details] proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=180606&action=review > Source/JavaScriptCore/ChangeLog:5 > + You need to add a 'Reviewed by' line.
Created attachment 180694 [details] for cq > > Source/JavaScriptCore/ChangeLog:5 > > + > > You need to add a 'Reviewed by' line. Hoops. Done.
Comment on attachment 180694 [details] for cq Clearing flags on attachment: 180694 Committed r138449: <http://trac.webkit.org/changeset/138449>
All reviewed patches have been landed. Closing bug.