Bug 105677 - [EFL [WebGL] GLES2 detection is broken.
Summary: [EFL [WebGL] GLES2 detection is broken.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Kalyan
URL:
Keywords:
Depends on:
Blocks: 105659
  Show dependency tree / graph
 
Reported: 2012-12-22 04:46 PST by Kalyan
Modified: 2012-12-24 02:04 PST (History)
6 users (show)

See Also:

Attachments
patch (1.41 KB, patch)
2012-12-22 05:36 PST, Kalyan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalyan 2012-12-22 04:46:25 PST 
We use the logic in FindGLES.cmake to detect GLES2 support during compile time. 

OPENGLES2_FOUND is never set, even though OPENGLES2_INCLUDE_DIR and OPENGLES2_LIBRARY contain right information.

The name passed to find_package_handle_standard_args seems to be the issue here. GLES2 should be changed OPENGLES2.

Will update a patch with the correction.
Comment 1 Kalyan 2012-12-22 05:36:48 PST 
Created attachment 180603 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2012-12-24 01:57:25 PST 
Comment on attachment 180603 [details]
patch

Looks ok to me, but I have to trust you on this one
Comment 3 WebKit Review Bot 2012-12-24 02:04:49 PST 
Comment on attachment 180603 [details]
patch

Clearing flags on attachment: 180603

Committed r138437: <http://trac.webkit.org/changeset/138437>
Comment 4 WebKit Review Bot 2012-12-24 02:04:54 PST 
All reviewed patches have been landed.  Closing bug.