Bug 105670 - IndexedDB: Surface a few more leveldb errors
Summary: IndexedDB: Surface a few more leveldb errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-21 16:40 PST by David Grogan
Modified: 2013-01-02 15:57 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.99 KB, patch)
2012-12-21 16:41 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Patch (5.15 KB, patch)
2013-01-02 14:04 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2013-01-02 15:26 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-12-21 16:40:01 PST 
IndexedDB: Surface a few more leveldb errors
Comment 1 David Grogan 2012-12-21 16:41:57 PST 
Created attachment 180573 [details]
Patch
Comment 2 David Grogan 2012-12-21 16:42:34 PST 
Josh or Alec, could you take a look?
Comment 3 WebKit Review Bot 2012-12-21 17:09:04 PST 
Comment on attachment 180573 [details]
Patch

Attachment 180573 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15452596
Comment 4 Peter Beverloo (cr-android ews) 2012-12-21 17:38:16 PST 
Comment on attachment 180573 [details]
Patch

Attachment 180573 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15449614
Comment 5 David Grogan 2013-01-02 14:04:23 PST 
Created attachment 181062 [details]
Patch
Comment 6 Joshua Bell 2013-01-02 15:23:40 PST 
Comment on attachment 181062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181062&action=review

lgtm

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:-58
> -    // FIXME: Convert all callers of get to safeGet then remove get.

Keep a FIXME saying "rename safeGet to get" ?
Comment 7 David Grogan 2013-01-02 15:26:25 PST 
Created attachment 181081 [details]
Patch
Comment 8 David Grogan 2013-01-02 15:31:49 PST 
Tony, could you review this?

Re(?)-cc jsbell/alecflett.
Comment 9 WebKit Review Bot 2013-01-02 15:57:00 PST 
Comment on attachment 181081 [details]
Patch

Clearing flags on attachment: 181081

Committed r138670: <http://trac.webkit.org/changeset/138670>
Comment 10 WebKit Review Bot 2013-01-02 15:57:04 PST 
All reviewed patches have been landed.  Closing bug.