The comments in instance-of-immediates.js describe what is being passed to the test function, testSet. The word "passsing" should be spelled "passing".
Created attachment 180574 [details] patch
LGTM, I guess it would make total sense to ask for r? and cq?. Let's see who can take care of this.
(In reply to comment #2) > LGTM, I guess it would make total sense to ask for r? and cq?. The change makes sense. Stuart are you posting this patch for review? BTW we really welcome spelling fixes but we usually prefer such massaging to occur as part of some other change (this is our policy for fixing style violations and extra white spaces). The rationale is to avoid unneeded churn when blaming the files.
(In reply to comment #3) > (In reply to comment #2) > > LGTM, I guess it would make total sense to ask for r? and cq?. > > The change makes sense. Stuart are you posting this patch for review? > > BTW we really welcome spelling fixes but we usually prefer such massaging to occur as part of some other change (this is our policy for fixing style violations and extra white spaces). The rationale is to avoid unneeded churn when blaming the files. Yes, I am posting this patch for review. Thanks for the note about fixing spelling, style, etc. during the course of some other change. I'll try to do that in the future.
Comment on attachment 180574 [details] patch Great, patches for review should have the r? flag set in the future.
Comment on attachment 180574 [details] patch Clearing flags on attachment: 180574 Committed r138524: <http://trac.webkit.org/changeset/138524>
All reviewed patches have been landed. Closing bug.