WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105664
[chromium] Use top level field for gesture event source
https://bugs.webkit.org/show_bug.cgi?id=105664
Summary
[chromium] Use top level field for gesture event source
Robert Kroeger
Reported
2012-12-21 15:01:58 PST
WebGestureEvent events of subtype GestureFlingStart had a field deviceSource to specify which device was the origin of the fling request. It is useful to have this field for other WebGestureEvent subtypes (in particular GestureScrollStart, GestureScrollEnd). Previously, a single top-level field was added to WebGestureEvent. Now that Chromium populates this field, use it in the Chromium WebKit layer.
Attachments
Patch
(11.93 KB, patch)
2012-12-21 15:16 PST
,
Robert Kroeger
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Robert Kroeger
Comment 1
2012-12-21 15:16:23 PST
Created
attachment 180563
[details]
Patch
Robert Kroeger
Comment 2
2012-12-21 15:19:23 PST
Comment on
attachment 180563
[details]
Patch nb: patch won't pass tests until Chromium deps are rolled into WebKit.
Robert Kroeger
Comment 3
2013-01-02 11:30:26 PST
As indicated by EWS results, the necessary DEPS roll has taken place.
Adam Barth
Comment 4
2013-01-02 12:10:15 PST
Comment on
attachment 180563
[details]
Patch ok
WebKit Review Bot
Comment 5
2013-01-02 12:18:14 PST
Comment on
attachment 180563
[details]
Patch Clearing flags on attachment: 180563 Committed
r138629
: <
http://trac.webkit.org/changeset/138629
>
WebKit Review Bot
Comment 6
2013-01-02 12:18:17 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug