Bug 105664 - [chromium] Use top level field for gesture event source
Summary: [chromium] Use top level field for gesture event source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-21 15:01 PST by Robert Kroeger
Modified: 2013-01-02 12:18 PST (History)
3 users (show)

See Also:

Attachments
Patch (11.93 KB, patch)
2012-12-21 15:16 PST, Robert Kroeger 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-12-21 15:01:58 PST 
WebGestureEvent events of subtype GestureFlingStart had a field deviceSource to specify which device was the origin of the fling request. It is useful to have this field for other WebGestureEvent subtypes (in particular GestureScrollStart, GestureScrollEnd). Previously, a single top-level field was added to WebGestureEvent. Now that Chromium populates this field, use it in the Chromium WebKit layer.
Comment 1 Robert Kroeger 2012-12-21 15:16:23 PST 
Created attachment 180563 [details]
Patch
Comment 2 Robert Kroeger 2012-12-21 15:19:23 PST 
Comment on attachment 180563 [details]
Patch

nb: patch won't pass tests until Chromium deps are rolled into WebKit.
Comment 3 Robert Kroeger 2013-01-02 11:30:26 PST 
As indicated by EWS results, the necessary DEPS roll has taken place.
Comment 4 Adam Barth 2013-01-02 12:10:15 PST 
Comment on attachment 180563 [details]
Patch

ok
Comment 5 WebKit Review Bot 2013-01-02 12:18:14 PST 
Comment on attachment 180563 [details]
Patch

Clearing flags on attachment: 180563

Committed r138629: <http://trac.webkit.org/changeset/138629>
Comment 6 WebKit Review Bot 2013-01-02 12:18:17 PST 
All reviewed patches have been landed.  Closing bug.